donalm / pg8000 Goto Github PK

According to the PostgreSQL documentation, the ErrorResponse message body consists of a set of fields separated by the null byte. Each field consists of one byte for the field type, followed by a string encoded in the current client encoding.

The docs explicitly state that these fields can appear in any order.

In core.py the handle_ERROR_RESPONSE method unpacks the field strings from ErrorResponse messages in order and passes them as arguments into ProgrammingError. It seems that ProgrammingError may expect these arguments to arrive in a specific order, so that the SQLSTATE (with prefix 'C') is the 1th argument.

PostgreSQL version 9.6 adds a new field to the ErrorResponse with prefix 'V', and (at least for me) this new field arrives as the 1th field in the message. This causes a test to fail because of this line:
self.assertEqual(e.args[1], '42P01') # table does not exist

Testing with postgres.app v9.6.1.0 and various pythons on OSX.