domsson / libkita

kita is a library to help you create, run and monitor child processes

libkita's Issues

Possible memory leak in libkita_child_del()

From the current rewrite (branch kita) of succade, see this valgrind log:

==32259== HEAP SUMMARY:
==32259==     in use at exit: 438 bytes in 12 blocks
==32259==   total heap usage: 326 allocs, 314 frees, 146,022 bytes allocated
==32259== 
==32259== 438 (24 direct, 414 indirect) bytes in 1 blocks are definitely lost in loss record 8 of 8
==32259==    at 0x4838D7B: realloc (vg_replace_malloc.c:836)
==32259==    by 0x4868F5C: libkita_child_del (libkita.c:493)
==32259==    by 0x4869F2D: kita_child_del (libkita.c:1372)
==32259==    by 0x4869D08: kita_child_free (libkita.c:1287)
==32259==    by 0x486A202: kita_free (libkita.c:1534)
==32259==    by 0x10FD03: main (succade.c:1376)
==32259== 
==32259== LEAK SUMMARY:
==32259==    definitely lost: 24 bytes in 1 blocks
==32259==    indirectly lost: 414 bytes in 11 blocks
==32259==      possibly lost: 0 bytes in 0 blocks
==32259==    still reachable: 0 bytes in 0 blocks
==32259==         suppressed: 0 bytes in 0 blocks
==32259== 

Possibly a memory leak in libkita? Something to investigate.

kita_child_read() can hang if there is nothing to read

Calling kita_child_read() after receiving a KITA_EVT_CHILD_READOK, where the size of the kita_event_s is 0 will hang indefinitely.

Alternative implementation using poll or select?

FreeBSD users have trouble compiling this because epoll isn't portable. Providing an alternative implementation using poll or select would solve the issue, but I have no experience with those (yet).