dombouman / more-css-practice Goto Github PK

Dom, the point of CSS Classes is so you can create groups of like elements and style them all with one ruleset. Instead of copying and pasting your class over and over, just make one!

 .bottom { 
   width: 33%; 
   float: left; 
   border: solid .5px; 
   display: inline-block; 
   padding-top: 3px; 
   padding-left: 3px; 
 }

Then give all three of those elements the same class 😄

<section class="bottom">
  <a href="https://placeholder.com"><img src="https://via.placeholder.com/100x100"></a>
  <p class="center"> Homes </p>
</section>
<section class="bottom">
  <a href="https://placeholder.com"><img src="https://via.placeholder.com/100x100"></a>
  <p class="center"> Experiences </p>
</section>
<section class="bottom">
  <a href="https://placeholder.com"><img src="https://via.placeholder.com/100x100"></a>
  <p class="center"> Restaurants </p>
</section>

Now all three look the same, and if you need to make a change, you only have to do it once for all of them!

You could get rid of the b tag and use font weight in CSS to make it bold like you wanted to or I think it was suppose to be a link so you could use a href instead.

You could have used a better order for your <h?> elements. If the browser made an outline of your page, it would look like this according to your headings:

1. About
    a. Legal
        i. About Us

Which isn't really a good representation of what the page is for. A better outline might be something like:

1. About Us
    a. The Team
        i. Kevin Systrom (CEO, co-founder)
        ii. Mike Krieger (CTO, co-founder)

Notice how each child is a sub-section of it's parent. That's how headings are supposed to work. Anything on the a-b-c level is under the main level and should be given an <h2> tag. Anything on the i-ii-iii level is a sub-section of something on the a-b-c level and should be given an <h3> tag. Notice how the nav sidebar isn't even showing? That's because it's not really part of the page content, it's just a helpful way to navigate to other pages. So there shouldn't be headings in the nav.

You should probably use more descriptive class names. When you're working with other people, they should be able to look at your CSS and have a pretty good idea of what elements the rules are applying to. If they see:

.sweet { ... }
.wow { ... }

They're going to have to search through all your HTML to spot those words, and they'll resent you for it, haha. Try using names that describe what the element does, like nav-list.