dodgez / snappy

A distributed version control system

👋 Hi, I’m Zachary Dodge (@dodgez)

👀 I’m interested in many different topics not limited to:

• Rust (and ecosystem)
• Haskell (and related category theory)
• Typescript
• SQL
• Linux and Windows Subsystem for Linux
• Git and Pijul
• Many more!

🌱 I’m currently learning anything I can get my hands on. Recently that was Rust, Ansi terminal escape sequences, and basic text editors: https://github.com/dodgez/redit

💞️ I’m looking to collaborate on game development, a Rust/Haskell/Typescript codebase, or anything on my interest list. I especially like working on things I would use personally like https://github.com/starship/starship.

📫 Send me an email at zacharysdodge(at)gmail.com

snappy's Issues

Extrapolate Snappy directory sanity checks

There are many places that explicitly check if the .snappy directory exists (and sometimes if other parts exist). This should be extrapolated into a function that gets called once (unless initializing a repository) or several functions that get called when an item in the repo needs to exist or be configured correctly.

Hash Object DRY Violation

There are multiple places in code where an object is hashed. This functionality should be consolidated into one place.

No existing check for duplicate commits

Steps to replicate:

1. Make some files with contents
2. Stage files
3. Commit files with some message
4. Commit files again with same message

The end result is two commits, the latter pointing to the former, though they are using the same tree object. This shouldn't be the case as there has been no new information to commit.

References, borrowing, and slices are used inconsistently

There are many places in the code where std::path::Path and std::path::PathBuf are awkwardly exchanged as well as String and &str.

Ideally, there would be some consistency.

Object Structures Dry Violation

Objects like commit, tree, and file have implicit structures used when extracting information. This should be extrapolated into explicit structures.

Decide on boundary for error handling

Finding unwrap would yield a large search result collection. A level of acceptable level of error handling needs to be decided.

For example, the following assumptions are specific concerns currently being ignored:

• Every file/dir read and write works correctly
• Files are formatted correctly