dnsev / 4cs Goto Github PK

In inline_replace_urls the script does this:

var text = tags[i].text();
[...]
full_text += text;
[...]
tags[0].before(full_text);

which has the effect of inserting the text from posts into the document as HTML.

To keep it close to the other submenus when there are scripts like OneeChan, 4chan X Name Sync, and ExLinks that add links to the bottom of the header menu.

Somewhere between 105 and 111 (higher value placing it lower) OneeChan has an order value of 120, and the other two have values of 112.

Since the 3.8.0 4chanX update the "Choose files" button overlaps the "Sounds" checkbox in the QR, making it unusable

Appchan X loads youtube videos inline with the thread, which I personally like better than the 4chan media player's youtube handling. It's probably a personal opinion. Is there a way to disable this? Right now, Appchan X's youtube feature doesn't work since 4chan media player works first.

I'm guessing it's the same with soundcloud. I really like it to be inline with the thread.

When I go to load a sound by clicking on the sounds button, rather than loading the sound (sounds does change to loading... but nothing ever actually loads) it just takes me to the top of the page. I am also unable to open the Media Player by going to Media Player->Open Player but I can open the Settings page. I'm using Scriptish 0.1.8 with 4chan Media Player 4.7.0.2 on Firefox 22.

If more details are needed let me know.

This has been an annoyance for Firefox users/myself when using 4cs to play sounds files. Greasemonkey's Javascript seems to run significantly slower than Chrome, and even embedded Javascript code.

This issue is going to be used to:

• Let people know that yes I'm aware this problem exists
• Perform some tests and put their results in here

This way, I can see if there's anything that can be done to make this less of a problem.

The userscript can be found here. It runs exclusively on this page.

Time to upgrade!
Not really though, just need to move the settings/menu link to somewhere accessible. (On main board pages)

It seems that with moots pushing 4chan x to Greasemonkey, the media player and uploading gets fucked over. Probably intentional. Just letting you guys know about this if you don't already.

I hit load all sounds at the top and it successfully loaded all the sounds in a thread up to a deleted image, after that all the sounds had a ... after the sounds link, and did not load automatically and did not load when clicked, had to refresh the page to enable them again. An exception needs to be made in the script for deleted files for this case.

When I try to load a link from Youtube it brings up the player but doesn't load automatically, and is unresponsive when I click the play button. I have not had any problems loading embedded sound images and the audio tag test worked fine for me too. Other sites such as Vimeo work fine. I've disabled my adblock and other scripts but that didn't fix anything.

Yo, your script has interoperability issues with mine (https://github.com/zixaphir/appchan-x/). I could fix it on my side, but it'd be considerably easier to patch on yours. Essentially, I'm asking a favor (please!). My script strips 4chan's default CSS by removing all style elements and link elements with a Style/CSS ref, providing they don't have an ID. If you could just add an ID to any style elements your script inserts, mine would simply ignore them.

I've tried writing in workarounds and various checks to try to prevent non-4chan default CSS from being removed on my side, but unfortunately they're very inconsistent, partially due to the inline extension's insistence on adding its CSS whether or not it's enabled.

This would be a huge favor to me and our users. Thanks.

After a point the Youtube video title will stop appearing and is replaced with Youtube: Video not found on all following links

I followed the guide on the download page and got my embedded image, but when trying to post the image on 4chan, it still knows I have an embedded image. What's more, is that whenever trying to post an embedded image that I saved from another poster, I have to put in the captcha on avereage about 20 times.

I have 4chanx V3, 4cs 4.5.2 , and I used Ogglify. 4chanX is on Greasemonkey, and 4cs is on scriptish, though.

edit: changing the 4cs install to greasemonkey didn't help

Doesn't seem work on with very large playlists, 50 or so seems fine, but 100+ just doesn't do anything. Clicking it has seemingly no effect. Is it a loading time, or can it not handle large playlists?

I'm assuming this change messed up sound uploading with the sounds form open

Upload Error
An error occured while attempting to submit your post.
This may happen due to script incompatability. If you want to use this feature, submit an issue request, or disable this feature and install a different upload script.
You can try to submit your post by closing the sounds panel.
Errors
Submit form key "name" could not be found.
Submit form key "email" could not be found.
Submit form key "sub" could not be found.

.MPMenu.MPMenuClosed.MPHighlightShadow2px.reply.post

Do you really need the .reply.post?

Whenever I have Oneechan enabled, a few things get in the way. One would be that whenever I use Hover preview for videos, it doesn't go away, and the second would be that the [media player] button at the top of the screen covers the filename for OP's image.

Since the Appchan X 2.6.4 update (and also in 2.7), the 4chan Media Player has stopped embedding YT links on the frontpage. Inside of threads everything is still fine.

Firefox 26.0
Greasemonkey 1.13
Appchan 2.7.0 (the issue was also in 2.6.4)

(I didn't know whether to post this here or on the Appchan issues page so I posted it on both)

Ok, I just got done with converting all .jpg and .png files. Took about a day.

-Some .png files came out completely corrupted. The majority of them (not sure if all) seems to be .jpg files that were converted into .png by the program.
Original:
choo choo TETSUMUSU
Encoded:
choo choo TETSUMUSU -embed

-Some of them came out slightly corrupted, like these:
Cirino
Cirino-embed
1342617019189
1342617019189-embed

-Why does the re-encoder resize small images into huge ones? Some of them are so expanded that they look horrible. Is this a bug or an optimization feature?

Feature request (When you have time):
1.Have the program automatically move re-encoded images into a new folder and take out "-embed" from the name.
2.Support for images with unicode names (Japanese)

Hope this helps. I'm running .gif files right now. If I notice anything else, I'll update this.

Again, thanks for working on this. It's awesome.

The load all sounds feature seems to be removed, or it's hidden; and the uploader is causing the 4chanx QR on onee-chan to stick out from where it's supposed be hidden

Greentexting an exlink seems to make 4cs+exlinks throw a fit.

Example (only works in 4cs, not just the browser)
http://i50.tinypic.com/14j9hqc.jpg

WHAT IS THIS WIZARDRY?

It's a jpeg, but it plays some kind of video...

Using AdblockPlus with the greasemonkey extension stops the embed from working.
I haven't explored options to exclude it from the filter, but if anyone runs into issues with the embed, take a look at adblock.

I'll fix this after it seems like 4chan's not undergoing any more changes. Possibly when other userscripts are fixed too, so I can maintain some compatibility.

XMLHttpRequest cannot load http://images.4chan.org/v/src/1370570732918.jpg. Origin http://boards.4chan.org is not allowed by Access-Control-Allow-Origin. I found this error by pressing ctrl+shift+j in Chrome and it shows the same error every time I press [sounds] next to the image name. The media player isn't working at all for me, it just gets stuck loading. Anybody else having this issue? Can I get some help?

The quick reply for Appchan X is being messed up by 4cs again... Now, after a sound image is posted, the cooldown timer doesn't start, so I have to manually gauge how long between posts.

Also, the filename doesn't disappear from the quick reply box automatically after it's posted like it should.

Oh, it also seems to prevent me from stopping an upload in progress...

i'm using chrome with tampermonkey, have no other scripts besides this one and sound uploader
when i'm clicking on embedded youtube links they just opens in another tab and refuses to play in the media player. sound files works perfectly though.
have tried resetting the settings, refreshing the page and re-installing the script.

I'd like to have an option to disable the youtube functionality of this extension, as I prefer youtube link title, and don't want both going off on me on the same page. Could this be added?
http://userscripts.org/scripts/show/83584
This is youtube link title, in case it is important.

Would it be possible to have the media player play .webm videos that have been embedded in the pixel data of an image with the old embed.exe encoder rather than with Videncode? It seems like it would be relatively easy to add, and it could be a valuable fallback in the likely eventuality that 4chan starts using slightly better filtering.

Is it really necessary there? Images can't be uploaded there.

After following the guide here http://dnsev.github.io/4cs/#guide?tips&video
At step 7 I encountered problems when I tried to upload image-embed.jpg, which I was promptly interrupted with a message informing that the image file has a embedded file. Therefore preventing me from using it.

This happened in /v/ board

Keep getting Ajax Error, I'm on Firefox 18.0.1.

Any chance for us to specify a hotkey that opens the media player instead of having to scroll up all the way to click [Media Player]?

I am going to assume it is related to the Firefox update (23.0) that was released recently as that is when I began to notice the issue, but other users have not had the issue. Basically, when I load an embedded sound, it loads fairly quickly. However, it takes about 15+ seconds to be put into the media player list and begin playing the actual sound. When it is loading into the media player list, it makes my browser so laggy so when I type text, it takes a few seconds to appear and scrolling is also delayed.

Tried reinstalling Greasemonkey and Media Player but still get the issue. Videos load fine in the media player and play with no delay, only sound in images. I disabled my other scripts in Greasemonkey but that did not help.

Do you think you could add in support for 38chan? Right now, the script works if you have a hotkey bound for opening the player and included boards.38chan.net/* in the script; you just have to drag images in the player itself.

I was wondering if you could make a minor adjustment to the script so we could see the media player script button on 38chan and have [tags] working

https://github.com/dnsev/4cs/blob/master/web/4cs.user.js#L10962
What does that even mean?
https://github.com/dnsev/4cs/blob/master/web/4cs.user.js#L8679
Why not apply a class? (i.e. MPMassSound)
Is there a specific reason you use div rather than span?

Title, I recently noticed in a post that only two links weren't working with the media player and it turned out they were the only ones with a _ and a - in them.
So basically any youtube link with special characters is fucked.

Edit: I really should have tested it before I posted.
That doesn't seem to be the issue.
So fuck me backwards.
Just ignore this.

It seems my 4cs wont load and tampermonkey gives me an error saying that my javascript settings or a scriptblocker is blocking it, but I've both disabled my script blocker and set javascrip to allowing java to run on all websites.

I have the latest versions of the 4chan Media Player, Firefox, Tampermonkey and 4chan X running on my computer. When I click the "sounds" link next to the images with sound in them, the player loads the sound file and image and the player registers that the music is being played (like it has the specific playtime and everything like usual). The problem is that no sound actually plays even though the player thinks it is, like the sound has been muted or something. Even when volume is at 100% it still does this.

I get a "System cannot find path specified." Error when I try using the batch program to re-encode old files.

This may be a long shot, since I don't really even know how 4cs works, or how it masks it's sounds in the images, but would it be possible to embed mp3 files in images too and play them? There's a javascript audio library called howler.js you may want to know about
http://goldfirestudios.com/blog/104/howler.js-Modern-Web-Audio-Javascript-Library

Apparently moot made some changes to the embedded archive filter, of four sounds i've tried, only two could be uploaded, the rest get embedded image errors.

Any way you can update the mask dnsev?

You have #qr > form:nth-child(2) > div:nth-child(4) (also known as the submit bar) go display: none !important; when opening the sounds section, but on closing the sounds section and revealing the submit button, the file and the sounds set up in the section below information is lost on dechecking the sounds button.
Even with custom CSS, your js overrides anything I do to save it.

I just switched from https://userscripts.org/scripts/show/154526 to your script, but now none of the masked files will play. I click them, and it loads, but the script's "window" won't display the image and nothing will play. Old files using older masks play correctly (such as the images in http://archive.foolz.us/a/thread/77601296/), as do images using stego, but new masks won't (such as most of those in https://archive.foolz.us/a/thread/78653026/).

For example, http://www.pictureshack.us/images/84179_440_-_La_Pucelle_-_sm7862914.jpg does not work (new mask), whereas http://www.pictureshack.us/images/64902_Stego.png does (stego).

You've updated your script recently, so I find it hard to believe that your script does not support the only working mask, but I installed the script and made no changes to it, so I don't think I'm doing anything wrong either.

This is really confusing... Does this really not support the most recent mask?

I'm using Chromium 25.0.1323.1 (Developer Build 167142) Ubuntu 12.10.

Currently when the userscript loads a masked multi-sound file such as

http://archive.foolz.us/a/thread/77601296/#77603712

it misses the magic numbers of all but the first Ogg file and therefore only sees one sound.

The problem appears to be the line

i += magic_strings_ui8[s].length;

which skips magic_strings_ui8[s].length bytes without properly updating the mask state. Commenting out the line causes all sounds to be loaded.

While, or any time after, a sounds image is selected with "browse" and it's info shows up, I am unable to enter the captcha, I have to reload the page for it to work. The only way I can post sounds with Appchan X is to enter the captcha, then select the sound image and press "submit", then reload the whole page (breaking any sound that's playing), and repeat for each image. Is there any way to disable the Appchan X/4cs "fusion"?

http://www.pictureshack.us/images/49803_borked_player.png

It's the same as the conflict with Oneechan. Previews for videos viewed in the foolz archive stay on the screen after taking your mouse off.

On longer threads which aren't loaded all at once, it seems that the "sounds" link is added, but 4chan-x parses it back out.

Fix this.