dnnrly / hoofli Goto Github PK

Describe the bug

https://github.com/dnnrly/hoofli/actions/runs/3308671654/jobs/5461226398

Oops.

Is your feature request related to a problem? Please describe.
Chrome has additional _initiator block. This seems to include information about what has invoked each network fall.

Describe the solution you'd like
It would be great if we could see which scripts or user events initiate network calls in our diagrams

Describe alternatives you've considered
Nothing yet. This appears to be specific to Chrome but this information might be present in other browsers

Additional context
n/a

Describe the bug
It appears that we aren't actually running any of our tests when we raise a PR. Could this be only for contributors? Or owners too?

Describe the bug
Some tests swap expected and actual result which leads to confusing outputs in case of failing tests. At time of writing, this affects these test methods:

• TestDrawHar_SinglePage in har_test.go:72
• TestDrawHar_MultiPage in har_test.go:117
• TestDrawHar_InitiatorTypes in har_test.go

To Reproduce
Steps to reproduce the behavior:

1. Break a test by replacing the contents of test/reference/plantuml/simple-example.puml with this is not puml code
2. Run tests
3. See test failure report for TestDrawHar_SinglePage reading:

   Not equal:
   expected: "@startuml ....."
   actual: "this is not puml\n"
   

Expected behavior
Test failure report should read

Not equal:
expected: "this is not puml\n"
actual: "@startuml ....."

Is your feature request related to a problem? Please describe.
When a request is blocked for some reason, the response is rendered with status code zero. Reading the field response._error might help in finding out why the request was blocked.

Describe the solution you'd like
Maybe show a note on the connection with the contents of response._error (for example net::ERR_BLOCKED_BY_CLIENT)

Describe alternatives you've considered
Maybe rework the colors used for highlighting the initiator so red can be used for blocked requests. In any case, the return from the request must not be shown.

Additional context
Example request (truncated for brevity):

{
  "_initiator": {...},
  "_priority": "Low",
  "_resourceType": "image",
  "cache": {},
  "pageref": "page_1",
  "request": {...},
  "response": {
    "status": 0,
    "statusText": "",
    "httpVersion": "",
    "headers": [],
    "cookies": [],
    "content": {
      "size": 0,
      "mimeType": "x-unknown"
    },
    "redirectURL": "",
    "headersSize": -1,
    "bodySize": -1,
    "_transferSize": 0,
    "_error": "net::ERR_BLOCKED_BY_CLIENT"
  },
  "serverIPAddress": "",
  "startedDateTime": "2022-10-28T16:29:31.302Z",
  "time": 6.7949999998973,
  "timings": {
    "blocked": 6.7949999998973,
    "dns": -1,
    "ssl": -1,
    "connect": -1,
    "send": 0,
    "wait": 0,
    "receive": 0,
    "_blocked_queueing": -1
  }
}