dnglab / dnglab Goto Github PK

Hello,

Latest libraw supports Lossy compressed CR3 https://www.libraw.org/news/libraw-202101-snapshot also ART supports it https://bitbucket.org/agriggio/art/wiki/Home

Commit https://bitbucket.org/agriggio/art/commits/2663d3e887d5f92c446b4d64010765df3432df4c

Maybe you can check the code ;)

Would be great to get this. thanks

I've added a new tiff library written from scratch, which is already used for DNG generation.

CR3 contains the EXIF Artist and Copyright tag, but currently not transferred to DNG.

Could you please include an arm64 build in your releases?! Sheer lack of compiling knowledge is the reason I'm asking ;) BTW I'm thrilled by the project and hope to see it grow! Thanks!

Are the sample files used by the tests available somewhere?

Hi, I got an error with my canon 85mm F.1.8 used on an EOS 90D:

Unknown lens model: 'EF85mm f/1.8 USM'. Please open an issue at https://github.com/dnglab/dnglab/issues and provide the RAW file

Thanks in advanced.

dnglab copies the CMT4 box (TIFF structure with EXIF GPS info) into DNG. But CR3 has invalid values for

• Exif.GPSInfo.GPSLatitude
• Exif.GPSInfo.GPSLongitude
• Exif.GPSInfo.GPSTimeStamp

These should be arrays of 3 rationals, but each tag only contains two rationals. The data structure is correct, but programs like darktable can't decode these tags.

This should be fixed by checking the array length and extend the value to 3 rationals if needed.

Spec says: This tag is an MD5 digest of the data stored in the OriginalRawFileData tag.

For Canon CR2 and CR3 files, there exists two white levels in metadata:

Per Channel Black Level         : 2048 2048 2048 2048
Normal White Level              : 13535
Specular White Level            : 14888

dnglab uses the Normal White Level while Adobe DNG Converter uses Specular White Level. This should be changed.

The White and Black level only depends on the choosen ISO value.

"Unknown lens model: 'TAMRON 28-300mm F/3.5-6.3 Di VC PZD A010'. Please open an issue at https://github.com/dnglab/dnglab/issues and provide the RAW file": RAW file is attached.

IMG_0820.CR3.gz

Great to see all the improvements to the recent releases! Not sure if this is the right place to ask for a feature request or even just sharing possible projects of interest.
Since I stumbled upon Gopro's GPR files with wavelet (VC5) compression (https://github.com/OgreTransporter/gpr via https://github.com/gopro/gpr) I wondered if this might be useful to the dnglab project. Having wavelet compressed CR3 files would be awesome!

Support is included in rawloader library, but not yet ported.

I assume most of the math done here can be speed up, for example with SIMD or better multi threading.

Missing Lenses:
Sigma 18-300mm F3.5-6.3 DC MACRO OS HSM | Contemporary 014
Canon EF-S24mm f/2.8 STM

I don't know enough rust to find an answer, but what is the purpose of the toml table full of lenses? Why not just copy the information from existing exif data? Are the other parameters used somewhere I haven't seen in the code?

dnglab convert writes:

Unknown lens model: 'EF-S18-135mm f/3.5-5.6 IS STM'. Please open an issue at https://github.com/dnglab/dnglab/issues and provide the RAW file
photo.tar.gz

Filmrolls contains a list of raw images.

• Uses CRAW codec and enc_type 3

This is currently hardcoded for CR3 decoder an only supports a few lenses.

Most wanted one.

Hello! Thank you so much for this tool! I was really excited to see a way I might be able to bring these CR3 files into Darktable on GNU/Linux, but it seems that dnglab doesn't quite support the camera which created the files. What's involved in adding support for different versions of the PowerShot cameras, and more specifically the SX70 HS?

I'd be happy to help, if you can provide some guidance.

Worth noting, I've verified that https://raw.pixls.us/ has images for this camera. If more are needed, I can provide them.

Output from running

~/projects/third-party/dnglab on main at 18:08:04 
❯ ./target/release/dnglab convert ~/sharebox/IMG_0694.CR3 test.dng
thread 'tokio-runtime-worker' panicked at 'called `Result::unwrap()` on an `Err` value: DecoderFail("File is unsupported: Couldn't find camera \"Canon\" \"Canon PowerShot SX70 HS\" mode \"\".\nPlease submit samples at https://raw.pixls.us/")', bin/dnglab/src/dnggen.rs:96:78
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: JoinError::Panic(...)', bin/dnglab/src/dnggen.rs:100:4

Some converted DNG files has corrupt jpeg data.

Hi, I'm using the Canon 90D with mainly two lens: the canon EF 50mm F1.8 and the canon EF 85mm F1.8.
I got the error message "Unknown lens model: 'EF50mm f/1.8 STM'. Please open an issue at https://github.com/dnglab/dnglab/issues and provide the RAW file".
I will provide as well shot with the EF 85mm F1.8 if I get the same issue.
Thanks a lot for your work, program is great and hugely usefull while waiting for native CR3 support in darktable.

I got a github error saying that the CR3 format is not supported, how can I give you the .CR3 files ?
I try to ZIP the CR3 file but got the error "is not included in the list".

Best regard,

014A5860.CR3.tar.gz
Unknown lens model: 'SAMYANG RF 14mm F2.8'.

Here is the .CR3 for this lens. Let me know if you need something else.
IMG_9260.zip

CR3 files with HDR PQ enabled contains no JPEG preview images. But these previews are used for DNG generation.