dmolesuc / typesafe_enum Goto Github PK

Steps to reproduce:

1. Clone typesafe_enum with SSH:

   $ git clone [email protected]:dmolesUC3/typesafe_enum.git
   

2. cd to the new clone and try to build the gem:

   $ cd typesafe_enum
   $ gem build typesafe_enum.gemspec 
   

Expected:

• gem builds.

Actual:

• Build fails with bad URI error.

  Invalid gemspec in [typesafe_enum.gemspec]: bad URI(is not URI?): [email protected]:dmolesUC3/typesafe_enum.git
  ERROR:  Error loading gemspec. Aborting.
  

The culprit code is here in the .gemspec:

origin_uri = URI(`git config --get remote.origin.url`.chomp)
spec.homepage = URI::HTTP.build(host: origin_uri.host, path: origin_uri.path.chomp('.git')).to_s

If we don't want to hard-code the URLs, we need to be actually clever here, not just half-clever, and convert [email protected] URIs to https.

Right now printing an enum instance produces something like

#<Stash::Indexer::IndexStatus:0x00564952a50e00>

when it would much more usefully produce something like

Stash::Indexer::IndexStatus::FAILED

or possibly

Stash::Indexer::IndexStatus::FAILED (value="failed")