Coder Social home page Coder Social logo

Comments (7)

cpinte avatar cpinte commented on August 18, 2024 1

Yes, it seems to work perfectly now.

from plonk.

dmentipl avatar dmentipl commented on August 18, 2024

Hi @cpinte. Thanks very much for raising this bug.

I noticed that the snapshot file is missing the internal energy. Try the following:

>>> import h5py
>>> f = h5py.File('hydrostatic_18790.h5', mode='r')
>>> list(f['particles'])
['divv', 'dt', 'h', 'itype', 'vxyz', 'xyz'] 

Is it converted from a standard Phantom file? Perhaps the converter has a bug.

from plonk.

cpinte avatar cpinte commented on August 18, 2024

Yes, the dump was converted from a standard phatom dump via phantom2hdf5

from plonk.

dmentipl avatar dmentipl commented on August 18, 2024

Does the standard dump contain the internal energy?

from plonk.

cpinte avatar cpinte commented on August 18, 2024

Yes, the internal is in the standard dump. I have added it to the dropbox directory.

from plonk.

dmentipl avatar dmentipl commented on August 18, 2024

I have added a bug fix in ddaaa1f that sets the pressure correctly from the internal energy if it's available. This should fix your issue as long as the internal energy is in the snapshot file.

The temperature was incorrect because the adiabatic sound speed, which is sqrt(gamma * pressure / density), was incorrect due to the problem in calculating the pressure.

The problem with the missing internal energy in the converted HDF5 file is in the phantom2hdf5 converter not writing the internal energy. Hopefully we can fix this in Phantom soon. See the ongoing pull request at danieljprice/phantom#39 for more.

from plonk.

dmentipl avatar dmentipl commented on August 18, 2024

Hi @cpinte, are you happy if I close this issue?

from plonk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.