dmenne / breathtestcore Goto Github PK

Hi there! The broom dev team just ran reverse dependency checks on the upcoming broom 0.7.0 release and found new errors/test failures for the CRAN version of this package. I've pasted the results below.

• checking examples ... ERROR

  ...
  > fit = nls_fit(data)
  > coef_by_group(fit)
  Error: `by` can't contain join column `lhs` which is missing from LHS
  Backtrace:
  [90m     [39m█
  [90m  1. [39m├─breathtestcore::coef_by_group(fit)
  [90m  2. [39m├─breathtestcore:::coef_by_group.breathtestfit(fit)
  [90m  3. [39m│ └─`%>%`(...)
  [90m  4. [39m│   ├─base::withVisible(eval(quote(`_fseq`(`_lhs`)), env, env))
  [90m  5. [39m│   └─base::eval(quote(`_fseq`(`_lhs`)), env, env)
  [90m  6. [39m│     └─base::eval(quote(`_fseq`(`_lhs`)), env, env)
  [90m  7. [39m│       └─breathtestcore:::`_fseq`(`_lhs`)
  [90m  8. [39m│         └─magrittr::freduce(value, `_function_list`)
  [90m  9. [39m│           └─function_list[[i]](value)
  [90m 10. [39m│             ├─dplyr::do(...)
  [90m 11. [39m│             └─dplyr:::do.grouped_df(...)
  [90m 12. [39m│               └─rlang::eval_tidy(args[[j]], mask)
  [90m 13. [39m└─`%>%`(...)
  [90m 14. [39m  ├─base::withVisible(eval(quote(`_fseq`(`_lhs`)), env, env))
  [
  Execution halted
  

• checking tests ...

   ERROR
  Running the tests in ‘tests/test-all.R’ failed.
  Last 13 lines of output:
    [90m 24. [39mdplyr:::common_by.list(by, x, y)
    [90m 25. [39mdplyr:::bad_args(...)
    [90m 26. [39mdplyr:::glubort(fmt_args(args), ..., .envir = .envir)
    
    ══ testthat results  ═══════════════════════════════════════════════════════════
    [ OK: 333 | SKIPPED: 4 | WARNINGS: 1 | FAILED: 6 ]
    1. Error: Result with default parameters is tbl_df with required columns (@test_coef_by_group.R#13) 
    2. Error: Options digits is served (@test_coef_by_group.R#33) 
    3. Error: Result with default parameters is tbl_df with required columns (@test_coef_diff_by_group.R#13) 
    4. Error: Result with Dunnett contrast only returns 3 groups (@test_coef_diff_by_group.R#24) 
    5. Error: Correct Dunnett contrast when reference value is given (@test_coef_diff_by_group.R#45) 
    6. Error: Options digits is served (@test_coef_diff_by_group.R#67) 
    
    Error: testthat unit tests failed
    Execution halted
  

I think the issue results from the following lines in R/coef_diff_by_group.R:

broom::tidy(confint(glh))[,-2] %>%
  left_join(broom::tidy(summary(glh)), by = "lhs", copy = TRUE)

We are no longer providing tidy() methods for model summary()s for maintainability purposes. Please use the tidy() method implemented for the model object itself.🙂

We hope to submit this new version of the package to CRAN in the coming weeks. If you encounter any problems fixing these issues, please feel free to reach out!

cleanup_data() calls dplyr::distinct() on a (deliberately) unnamed data frame in one of the tests. At some point dplyr will stop accepting such broken data frames and/or call tibble::repair_names() and talk loudly about it (tidyverse/dplyr#3424). Until then it is advisable to ensure that the input to a dplyr verb is a well-formed data frame.

I'll make sure that distinct() keeps supporting unnamed data frames in dplyr 0.7.5.