dmbaturin / ocaml-tsort Goto Github PK

Consider the following dependencies: 1 -> 2, 3 and 2 -> 1. A natural but inappropriate way to specify it is [(1, [2]); (2, [1]); (1, [3])], in other words, a list where each pair expresses some possibly incomplete dependency. The current behaviour of Tsort on these is not consistent: sometimes it rejects the input with an assert false and sometimes it computes the meaningful output.

utop # let l = [(1, [3]); (2, [1]); (1, [2])];;
val l : (int * int list) list = [(1, [3]); (2, [1]); (1, [2])]
──────────────
utop # Tsort.sort_strongly_connected_components l;;
- : int list list = [[3]; [2; 1]]
──────────────
utop # let l = [(1, [2]); (2, [1]); (1, [3])];;
val l : (int * int list) list = [(1, [2]); (2, [1]); (1, [3])]
──────────────
utop # Tsort.sort_strongly_connected_components l;;
Exception: Assert_failure ("src/lib/tsort.ml", 287, 22).

It would be nice to

• Have a consistent behaviour: always reject (with a readable error message), or always accept these inputs
• State how such inputs are treated in the documentation.

I'd like to set up CircleCI before making a release. It's free for open-source projects and would give us a guarantee that a release will work for a desired range of OCaml versions.

It requires the github project owner to:

1. Create a CircleCI account
2. Add the project from the CircleCI dashboard
3. Add me as a contributor on the CircleCI project so I can set things up

The setup will consist in adding a .circleci folder to the github project, which CircleCI will use to build the project with every commit and notify us if something fails. See https://github.com/mjambon/dune-deps/tree/master/.circleci for an example.