dlr-sr / faulttriggering Goto Github PK

Problems wen using an array of fault triggering blocks. The naming of the busses becomes [1]. These names are no proper modelica.

Probable solution: replace brackets by underscores.

HTML Tidy gives some minor warnings,
search for FaultTriggering here:
https://build.openmodelica.org/Documentation/tidy.filtered

Since the release branch is set as default branch and some contributers address their pull requests w.r.t. the release branch and others w.r.t. the master branch it is hard to tell which branch is the preferred branch for contributions.

Having a link on the FaultTriggerContorller Interface that leads to the faulty model within the Wrapper would be nice. This avoids searching and clicking around to find the faulty model that could be a few layers down in the wrapper.

The link (or all links) could be on the documentation side of the FaultTriggerController listet in a table. If possible, the table shows which source block (e.g. Boolean Step) controls which fault. (1. column: name of the source block, 2. column: link to the fault)

Another possibility is to create a link on the Diagram interface where you see the source blocks. Just as the path of the bus connecting is showed, a direct link to the fault would be the most fast way.

Add checkbox to replace excisting files in the package generator

Hello,
I am haveing issues regarding the following package configuration:
FaultTriggering - Version 0.6.2
Dymola - Version 2015 DF01
Modelica - Version 3.2.1
ModelManagement - Version 1.1.3

All models (even the example "actuator") that I used to execute the createFaultPackage function led to an error: "Error: Failed to open or read ~FMUOutput\modelDescription.xml"
Did anyone else fight the same problem? Any solutions or hints?

Cheers
Jakob

Why are the booleanFaults disabled whereas realFaults and integerFaults are enabled?

Missing image file modelica://FaultTriggering/Resources/Documentation/RealVariableFault_level2.png is referenced by FaultTriggering.UsersGuide.Tutorial.FaultModelling.

When fixing the Modelica URIs I noticed that the links to FaultTriggering.FaultProcessing and FaultBus.FaultsInput do not work out.

At the moment there is a problem with single faults in the model. I have to fix it, but I do not have the time at the moment.

Hi,

I found 3 minor issues when using the latest released FaultTriggereing Library:

• a GUI choice misspelled true as 3, giving clear errors on PedanticCheck
• a reference to Modelica_Noise that should be Modelica.Blocks.Noise instead
• a missing uses annotation for AdvancedNoise, as well as missing instructions that it is needed as well.
  the only remaining error in Dymola 2018 pedantic check after that is a reference to '__Dymola_interactive' in an annotation.

I have not done any more detailed checking, but all of the above is easy to fix.

i am unable to run the Actuator Model through the createFaultPackage
resulting in Error:
Note: No "faultTrigger" component is defined. A default faultTrigger component will be used.
Inconsistent automatic inner faultTrigger.
Component context: faultTrigger
Component declared as FaultTrigger faultTrigger in FaultTriggering.FaultOutput
File: ...FaultTriggering-0.6.6/FaultTriggering/FaultOutput/Internal/InternalBooleanFault.mo, line 5
Component context: motor.ktFault.faultTrigger
Component declared as FaultTrigger faultTrigger in FaultTriggering.FaultOutput
File: ...FaultTriggering-0.6.6/FaultTriggering/FaultOutput/Internal/InternalIntegerFault.mo, line 5

ERRORS have been issued.

Also same error when Checking model aswell as Checking or running createFaultPackage on a new device with Faults added.

The Dialog annotations label, button, onlyStart, fields, treeView, rowHeadings and columnHeadings are non-standard Modelica and should be prefixed by a vendor-specific annotation prefix.

If 2 submodels have te same name, the bus system gets problems because of recursion. Posseble fix: Drectly store the busses in an hierachical way like the model is set up.

Could you use the FaultTrigger example from the AdvancedNoise library in your library, too?
See: https://github.com/akloeckner/AdvancedNoise/tree/fault_trigger

Dymola2016 does not export protected variables, which destroys the FaultTriggering.

Workaround:
remove "protected" from:
FaultTriggering.FaultOutput.Internal.InternalBooleanFault
FaultTriggering.FaultOutput.Internal.InternalIntegerFault
FaultTriggering.FaultOutput.Internal.InternalRealFault

Sadly, this library relies on the encrypted Dymola library ModelManagement and therefore is neither free to use nor tool-independent.

Redeclared replaceables are not found by the fault finding mechanism.

Possible solution: Move to FMI.

FaultTriggering.Examples.MotorExample.Driveline is referenced from documentation of FaultTriggering.UsersGuide.Tutorial.FaultModelling but not within the library.