Coder Social home page Coder Social logo

node-roku's People

Contributors

dlenroc avatar github-actions[bot] avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

Forkers

triwav

node-roku's Issues

Regex pattern that injects createObject("roSGNode", "ODC") can cause certain roku apps to crash

The regex pattern const pattern = /(\.show\(\))/gim; that injects createObject("roSGNode", "ODC") can cause unexpected injections in some scenarios.
I am currently working on a couple of Roku channels that set a string to showEventMessage = "example.show()".

When using the current pattern, this injects an additional unexpected createObject("roSGNode", "ODC") that looks like this:

showEventMessage = "example.show() : createObject("roSGNode", "ODC")"

The misplaced quotes cause compilation errors.
Unfortunately I am unable to modify the roku app but a workaround I found was changing the pattern to:

const pattern = /(\.show\(\))(?![\w"])/gim;

https://github.com/dlenroc/node-roku/blob/main/packages/odc/src/internal/injector.ts#L61

Would you consider publishing a new package that account for this scenario?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.