dknight / isikukood-js Goto Github PK

As the title states.
I could get "valid" isikukood that has invalid day value '00'.

Eg. running following code to get random varies from range 0 - 29 not 1 - 29.

Math.round(Math.random() * 31);

the correct way would be

Math.floor(Math.random() * 31) + 1;

Related problemous lines:
isikukood.js#L209
isikukood.js#L211
isikukood.js#L213

Validation allow to put personal id code like 01010101010

There is a problem with the last update. It is regarding to Date::getYear() method that is actually deprecated and returns 1xx for years starting from 2000.

Eg. '60311213742' this is not valid as Date::getYear() returns 103.

As Date::getYear() is deprecated Date::getFullYear() should be used instead.

Thank you for your library!
That would be great to include TypeScript definition files in your library.

Please see mjs build, as it currently slightly differs from others.
After build you have lost parenthesis here, for example. Thus this code will not get random gender based on the provided input. :)