djuttmann / sm3e Goto Github PK

Hello,

I've found bugs in Compression.cs:

Compress method:

• "if (i - CopyLengths [i].Address < 32)" => not 32 but 0xFF as the address is stored on one byte, otherwise it uses WriteCopy instead of WriteNegativeCopy which uses one more byte

CalculateWordFill method:

• if carry == 3 write 2 instead, because no compression is achieved when replacing [b0, b1, b0] with [cmd, b0, b1]
• missing last carry value in WordFillLengths

MatchSubSequences method:

• the method was buggy, I've replaced its content

You can find the corrected code there (it's in Python): https://github.com/theonlydude/RandomMetroidSolver/blob/master/compression.py

Anyway, thanks for your work on SM3E, we've used it as a documentation when we needed to get the doors information (for the areas randomization) and now the compression/decompression (for the palettes randomization) for the VARIA Randomizer.