djoksimo / srvice-api Goto Github PK

refactor/rearrange code so that isOwner methods can be plugged in as middleware with less repetition.

currently have to create separate isOwner function for every service.

https://github.com/srvice/srvice-api/search?q=isOwner&unscoped_q=isOwner

Idea: reduce repetition of this code with same flexibility.

Research best options relating to mongodb document ownership

The agent can review the user after matching with them, based on a 5-star rating + text comment

Docker pivot

Having an isApproved bool is easy to hack so we have to come up with a better solution.

Potentially can use:

https://www.npmjs.com/package/accesscontrol

https://mongoosejs.com/docs/guide.html#timestamps

• Test db change (for src/services/ServiceService)
• Test createService for serviceManager change (src/managers/ServiceManager)
• Test [POST] /service/ endpoint for creating services using supertest (https://github.com/visionmedia/supertest)

Add .vscode with settings.json and extensions.json (similar to srvice-mobile-agent) with recommended extensions (eslint, gitlens, prettier, etc.) and appropriate configurations (auto lint fix on save, etc ).

Look at other open source express / node projects for inspiration.

Add prettier configuration as well

Each category will have different placeholders for inputs:

e.g, hair styling: "Jane Doe's Barber Services", tutoring: "Jane Doe's Elementary School Tutoring"

Restrict ability to post service with id that doesn't match agent field in payload

Any find methods findById, find, .... should be wrapped in a utility function called findNonDeleted that allow us to perform queries as we normally would with mongoose. Model.find.....

We'll work on this one together @nipunlamba1

When you delete an item that exists in other collection, it should be cleared from the respective array field.

E.g when you delete a service, the agent should not contain that service in its array of services

All the isOwner functions follow the same pattern:

We can abstract the isOwner function so that you can pass in the model, document id, and agent id, but we'll leave that for a rainy day.

Originally posted by @djoksimo in #53

We currently have no local db and seeding scripts for populating the db with some initial data.

This ticket will make development experience significantly better.

1. Create a local db for the isRunningInDev environment using . MongoMemoryServer

• reuse logic from mongoHelper.ts and src/index.ts to create an in-memory local database.

2. Create some mock data files (typescript objects and arrays) (similar to the files in src/test/mock).

3. Create a script called seed.ts that can be called via npm run seed by adding "seed": "npx ts-node <path-to-seed.ts>" in package.json.

Acceptance criteria

• the developer should be able to run a script that creates a mock agent account, some services, attach some offerings to those services, attach some ratings to those services
• the script should create the seed data using chai to make local HTTP requests that call our POST and PATCH endpoints.
  ^ see mock/CLIGen and mock/MockGen for inspiration.