djetelina / pycarddeck Goto Github PK

I started writing tests with classic unittest.TestCase in mind, they should be rewritten into py.test format (just functions and asserts if I understand py.test correctly) :D

While at it, test coverage should be increased back to 100% ;)

Right now, Documentation is all on a single page. As the library expands, it'll be useful to have a structure for paging. Also each example from examples subfolder should be in documentation in it's raw form, so that people don't have to go to source and can just look at them while reading up on how to use the library

Similar code found in 2 other locations (mass = 44)

https://codeclimate.com/github/iScrE4m/pyCardDeck/pyCardDeck/deck.py#issue_57f8baa746b0df0001000032

Is there a functional test possible for this libary that wouldn't just duplicate already existing unittests?

Dependabot couldn't authenticate with https://pypi.python.org/simple/.

You can provide authentication details in your Dependabot dashboard by clicking into the account menu (in the top right) and selecting 'Config variables'.

View the update logs.

There should be examples of usage.

These examples don't have to containt the game logic, but only the parts where pyCardDeck is relevant

By writing those, we'll:

• show how a to have a nice card object that will utilize the library
• highlight what is missing in the library
• check if the library is pleasurable to work with (very important)

Examples to write:

• Poker
• Exploding Kittens
• Blackjack
• MtG or Hearthstone (drafting or deck management)
• Old maid
• Mau Mau
• Quartets or Go Fish
• War

When using the pyCardDeck.deck.Deck.load_standard_deck() function, the following error occurred:

Traceback (most recent call last):
  File "examples/blackjack.py", line 175, in <module>
    Player("Simon")])
  File "examples/blackjack.py", line 26, in __init__
    self.deck.load_standard_deck()
  File "/home/$USER/anaconda3/lib/python3.5/site-packages/pyCardDeck/deck.py", line 378, in load_standard_deck
    data = yaml.load(open(location)).__dict__
FileNotFoundError: [Errno 2] No such file or directory: '/home/$USER/anaconda3/lib/python3.5/site-packages/pyCardDeck/standard_deck.yml'

I checked and confirmed that it was not there, and pasted the file from this repository into the pip-installed directory, and it ran correctly.

Full problem here: http://stackoverflow.com/questions/39530802/tox-running-command-based-on-env-variable

1up tests, because tests are good.

It's good to have the ability to export a deck into a JSON format(file) and later import from the very same file, so that decks can be easily shared and replicated.