Coder Social home page Coder Social logo

Comments (3)

andrewgodwin avatar andrewgodwin commented on August 17, 2024 3

Yes, that's a good point - a decorator would do the job, if you think that would work? Something like:

@websocket.close_on_error
def connect(message):
    raise ValueError()

I don't want to make the actual function itself special in any way. There's also the potential for something like a class-based-view approach.

from channels.

bastianh avatar bastianh commented on August 17, 2024

I guess that would be a solution that would not require any changes.

I would prefer a solution that would directly work in the request where the websocket ist created (to fail that with forbidden for example) but I guess thats not easy to do.

from channels.

andrewgodwin avatar andrewgodwin commented on August 17, 2024

New ASGI stuff has fixed this, if the connect handler fails the websocket handshake is not even finished.

from channels.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.