dixhuit / macsible Goto Github PK

The tower role should no longer depend on the git role but will be able to point to the Homebrew git binary still via a default variable (the default value should probably be the Tower provided binary though).

This could make for less repetition when applying common tags. E.g. The "last" group of roles could be wrapped in a block and the last and always tags applied to the block rather than each role.

• http://docs.ansible.com/ansible/latest/include_role_module.html
• http://ansible-docs.readthedocs.io/zh/stable-2.0/rst/playbooks_blocks.html

Carefully reduce how much is tested by Travis to avoid build timeouts.

https://github.com/geerlingguy/ansible-role-composer

[WARNING]: when statements should not include jinja2 templating delimiters
such as {{ }} or {% %}. Found: git_push_default_result.stdout != "{{
git_push_default }}"

See https://travis-ci.org/danbohea/macsible/jobs/290175544

ansible-playbook mac.yml --syntax-check currently raises deprecation warnings about the use of include:

[DEPRECATION WARNING]: The use of 'include' for tasks has been deprecated. Use 
'import_tasks' for static inclusions or 'include_tasks' for dynamic inclusions.
 This feature will be removed in a future release. Deprecation warnings can be 
disabled by setting deprecation_warnings=False in ansible.cfg.

import_tasks was new in Ansible 2.4:
https://docs.ansible.com/ansible/2.4/import_tasks_module.html

I currently only seem to use it in roles/macos/tasks/main.yml.

Tests too often fail for taking too long. Some of the longer tasks are the ones that need to loop through a long list of packages to install e.g. atom role. These lists could be much shorter in a test environment so we need a mechanism for switching to a list of alternative variable overrides when testing as opposed to when installing for real (but still storing as much non-sensitive data in version control as possible, so not simply using config.local.yml for all "real" overrides).