dipeshsukhia / laravel-country-state-city-data

World`s Country State City Data Provider for Laravel

dipeshsukhia.github.io

Hello 👋

I'm Dipesh Sukhia, Software Developer extraordinaire. Welcome to my GitHub profile.

From INDIA 🇮🇳 .

Email: [email protected]

Website: dipeshsukhia.github.io

laravel-country-state-city-data's Issues

States duplicates

This data has a duplicate of states.
For example:
['id' => '3784', 'country_id' => '228', 'name' => 'odes'ka'],
['id' => '3785', 'country_id' => '228', 'name' => 'odessa'],

But must be only one of them, "odes'ka"

Laravel 8 supprt

Enhancement

• You could create methods to get related countries, states and cites.

Incorrect References

States should always be referred to as First Order Geopolitical Divisions. Only 17 countries of 249 have first-order divisions called 'State' or 'States'. See https://gadm.org/. I highly recommend providing a source and metadata regarding the format. Currently, all of the country names are lowercase, which is not particularly useful.
I know this may seem a bit overzealous, but I assure you, this information is important.

Feature: Enhance Countries Table with Currency Code and Calling Code

Background:

The current state of the project's countries table does not have fields such as currency_code and calling_code. Example for the United Kingdom is GBP and +44 . These fields play a crucial role in various functionalities, including internationalization, financial interactions, phone number formatting, and communication features. Adding these fields will not only improve the completeness of the data but also enhance the overall usability and user experience of the package.

Issue:

I propose to enhance the existing countries table by incorporating two new fields: currency_code and calling_code.

Tasks:

1. Database Schema Modification:

   • Add a new column named currency_code of the appropriate datatype to store the currency_code field to hold currency codes such as USD, EUR, JPY, and more.
   • Add another column named calling_code to store the international calling code associated with each country.

2. Data Migration:

   • Implement a data migration script to populate the currency_code and calling_code fields based on reliable data sources, such as official international standards.

3. Codebase Updates:

   • Update relevant parts of the codebase to use the newly added fields when displaying country-related information.
   • Modify any user interfaces that interact with country data to incorporate the currency_code and calling_code information.

4. Documentation:

   • Update the project's documentation to reflect the changes made to the countries table schema.
   • Provide clear instructions on how to use the currency_code and calling_code fields in various parts of the package.

5. Testing:

   • Create comprehensive unit tests to ensure the correctness of the new schema and data migration process.
   • Perform thorough integration testing to verify that the application functions as expected with the updated country information.

6. User Impact:

   • Users will benefit from the added currency_code and calling_code information when working with internationalization features, financial interactions, and communication functionalities.
   • Developers will find it easier to integrate phone number formatting and related features.

Expected Outcome:

Upon successful implementation of this enhancement, the countries table will be enriched with currency_code and calling_code fields, providing users and developers with valuable country-related information. This enhancement will contribute to a more comprehensive and user-friendly experience within the package.

Inconsistent data

The current version has a lot of inconsistent data, Yugoslavia is not a country and Kosovo is missing. There might be other inconsistent data too but that's what I noticed at first sight.

Change madinat dimashq record

Hey,

in your data provider you have the following record

['id'=>'3464','country_id'=>'213','name'=>'madinat dimashq'],

which should be changed to either:

['id'=>'3464','country_id'=>'213','name'=>'damascus'],

Since Dimashq is the Arabic name and Damascus is the English one https://en.m.wikipedia.org/wiki/Damascus

It would be best if you match your data with this list https://en.m.wikipedia.org/wiki/Governorates_of_Syria

Timezones?

Is it possible to add timezone data to cities or states?

Data mixed

Dear Dipesh,
I just used your package, it easy to use, but you have mistakenly mixed few cities under the wrong states
e.g. Amritsar is being shown under Punjab(India) and Punjab(Pakistan). I will be glad if you can please review.
Sincerely,

Duplicated and wrong data for a state

{
        "id": 1802,
        "country_id": 107,
        "name": "abruzzi"
}

This data is wrong. The only correct is the data with id 1803.