dinma-daniel / mobilelayout

MobileLayout

A simple mobile layout using .xml

mobilelayout's Issues

✅ Final project feedback

Hello Dinma,

Well done, you managed to get almost everything working! A bit more polish and it's ready for the Google Play Store 🙂.

I'm going to make a list of improvements, these are just small things that you can improve for your next (android) app:

• My first comment is advice for the future, you should always double-check what you've committed and, ideally, you should make a clean checkout just to confirm that the project is running without any problem. I'm saying this because you have a class - Interface - that contains errors and with it, I'm unable to compile the app. In any case, don't worry, I just removed it to test everything.
• You should improve your screens consistency, the first one has an initial support for dark mode while the second doesn't. You can always opt-out and having only one theme, but you should try to be consistent.
• You have some imports that are no longer used, you can go to Code > Optimize Imports to automatically remove them
• Your final project has files from the homework and the classes, you should only have code from the project itself. It reduces readability

These are just a couple of suggestions. Really looking forward to seeing what you're going to build next!