dimil / nfcd Goto Github PK

There are some API need to be support after LLCP link is established
Those API can be reference from Android

• NativeLlcpConnectionlessSocket.java
• NativeLlcpServiceSocket.java
• NativeLlcpSocket.java

Need also implemented in nfcd

libnci is not a good name here, because it's the glue code between the actual NCI library( which could be libnfc-nci).

We'd rename it and consider moving it to other folder.

The README doesn't contain the correct information about this repository.

From the specification v1.4, there's a INIT_PDU sent to gonk when gonk connects to the nfcd.

We should add a INIT_PDU.

nfc daemon should handle NDEF read request from gecko.
Currently the nfcd already contains the logic to handle this request, but not yet verified.

use vector just because need to know the size of array.
We did not use other function provided by vector
Change to a self-define structure with pointer to byte array and record the size is more efficient

Generic code is put under /src
Chip-specific code is put under /src/xxx

Should define a more clear interface , so vendor or mozilla side can know what interface should be implemented to support a new chip

There are many classes which is prefix with Native.

Native here doesn't have any meaning, we should remove the 'Native' prefix.

Should establish p2p connection when nfcd receive this notification

When setting page disable NFC function.
nfcd process should be killed.
Also need to make sure resource is release when process terminted

Current the naming of API is not consistent with other class
Ex.

static void nfc_service_send_MSG_LLCP_LINK_ACTIVATION(void* pDevice);
static void nfc_service_send_MSG_LLCP_LINK_DEACTIVATION(void* pDevice);
static void nfc_service_send_MSG_NDEF_TAG(void* pTag);
static void nfc_service_send_MSG_SE_FIELD_ACTIVATED();
static void nfc_service_send_MSG_SE_FIELD_DEACTIVATED();
static void nfc_service_send_MSG_SE_NOTIFY_TRANSACTION_LISTENERS();

should rename the API

The lib folder contains
libnfc-nci.so, (https://bugzilla.mozilla.org/show_bug.cgi?id=906577)
and nfc_nci.mako.so (https://bugzilla.mozilla.org/show_bug.cgi?id=906590)

When these two bugs land, we should remove the lib folder.

nfc daemon should handle NDEF read detail request from gecko

There are two classes

• NativeNfcTag
• NfcTag

seems doing Tag things.

I am guessing one of them should be removed.

nfcd already contains the logic about it, but not yet verify with tag device

nfcd should process this notification and inform GAIA

nfc daemon should handle NDEF write request from gecko

Currently Android.mk is written by assuming nfcd is located in B2G/system,
but in fact it could be located in any folder under B2G.
We should remove those absolute paths inside Android.mk

nfc daemon should handle NDEF push request from gecko

Currently the daemon still needs jansson (a JSON library written in C) to parse JSON message, when https://bugzilla.mozilla.org/show_bug.cgi?id=902051 is landed, we should remove jansson library.

From the protocol specification between Gonk, we also need another parameter called 'sessionId', and this session id is valid between a tech-discovered and a tech-lost notification.