diglol / crypto Goto Github PK

Refer: #27

Let me create a PR for you, which will add Siphash and Halfsiphash support.
I need it myself, and already have a working kotlin implementation.

Might need some help to verify which platforms are supported.

More info on Siphash: https://en.wikipedia.org/wiki/SipHash
HalfSipHash-2-4 is quite popular due to its good security-versus-speed tradeoff.
It is used in some crypto applications -> that is how I found this library.

Hi first of all great library!

I want to use AES/CBC/PKCS7Padding and I noticed that the jvm implementation uses AES/CBC/PKCS5Padding where the darwin one uses AES/CBC/PKCS7Padding

Any reason for that? would you accept a PR where the padding is passed as parameter and the user can specify which padding to use ? thanks!

Hi there!
Thanks for your great library.

I have a question: why nonce size in XChaCha20 is strictly 32 in bytes, or NONCE_SIZE == 24.
In my case i need NONCE_SIZE to be eqal to 12.

Encryption with 12 value works fine, but decryption in method hChaCha20 fails with crash.

Hi I have a question about the implementation of AesCbc:
I see that the result of encryption is prefixed with the iv and the decryption, instead, removes the iv decrypting.

Is that a reason for this? from the RFC or usage examples of the Cipher dont do anything similar.

Even the tests vectors from https://datatracker.ietf.org/doc/html/rfc3602#section-4 the cipher does not include the iv and the assertions you implemented need to modify the result to match the test vectors.

Thanks for that!