diefenbach / lfs-theme

The default theme for LFS

• 👋 Hi, I’m @diefenbach
• 👀 I’m interested in Python and Django
• 🌱 I’m currently learning more English
• 💞️ I’m looking to collaborate on cool stuff
• 📫 How to reach me: @diefenbach on Twitter

lfs-theme's Issues

CSRF problem

Category with products listing causes CSRF problem error raised from the {% sorting %} tag -

lfs-theme/lfs_theme/templates/lfs/catalog/categories/product/default.html

Line 5 in d71caec

{% sorting %}

Related to similar problem solved by c8ed9e8

templatetag throws AttributeError

Lines 30 and 38 of lfs-theme/templatetags/lfs_theme_tags.py will throw an AttributeError if another app passes a 'category', 'product' or 'page' to context that does not have an 'id' attribute.

In our case, django-photologue is passing an int object as 'page' via the url /photos/gallery/page/1/.

We have applied a workaround to test for the id attribute...

    if object is None or not hasattr(object, 'id'):
        object = lfs.core.utils.get_default_shop(request)

Fix - Form Fields Not Displaying

I had weird issue in that the address form fields did not appear at all. I finally managed to track the issue to the lfs/shop/lfs_form.html file. The variable for the form should be lfs_form and not form. Once that change was made then all the form fields appeared!

" missing

line 49 change <div class="prices" itemprop="offers" itemscope itemtype="http://schema.org/Offer>
to

http://schema.org/Offer

In product_inline.html change itemtype="http://schema.org/AggregateOffer"> to itemtype="http://schema.org/Offer"> since itemprop="price" belong for Offer. Or keep 'AggregateOffer' and change to itemprop="lowprice"

SlotsInformation, has_portlets and show="False"

Try a category with only the Filter portlet in one portlet. Then look at one or many products of this category. The bug (offset in slot) cames from the function 'has_portlets' in
lfs-theme / lfs_theme / templatetags / lfs_theme_tags.py. In this case 'has_portlet' is True because parent of the product = category has one portlet, but the rendered of this portlet is empty with show="False" in the product.
To fix it, I suggest to remove 'has_portlet' by a new function : has_portlets_rendered
def has_portlets_rendered(obj, slot,context):
portlets_list = []
rendered_list = ''
while obj:
portlets_list = portlets.utils.get_portlets(obj, slot)
for p in portlets_list:
rendered_list = (''.join(p.render(context)))
if len(rendered_list.strip()) > 0:
return True
if portlets.utils.is_blocked(obj, slot):
break
try:
obj = obj.get_parent_for_portlets()
except AttributeError:
break

return False