diced / serverstats

Visualize your Minecraft server statistics in realtime

hi

serverstats's Issues

[BUG] Stopping ServerStats-Worker

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. When stop server, Server always say Stopping ServerStats-Worker and server can't close

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Please complete the following information):

• OS: [e.g. Linux, Windows, macOS]
• Server Software: [e.g. Bukkit, Paper, Spigot, Fabric, Bungee]
• ServerStats Version: [e.g. 1.2.0]

Additional context
Add any other context about the problem here.

Carpet should not be required

According to the documentation, Carpet is used to get ticks per second and milliseconds per tick. However, Carpet adds several more invasive features which should not be required just to use this mod.

[BUG] Server enters crash loop after adding ServerStats

Describe the bug
As soon as i added this to my Fabric server and restarted, the server entered a crash loop...

To Reproduce
Steps to reproduce the behavior:

1. run a Fabric server through the itzg/docker-minecraft-server image
2. add ServerStats to the mods folder
3. restart the server
4. see crash loop

Expected behavior
The server should not crash loop and work as normal

Please complete the following information):

• OS: Ubuntu Server
• Server Software: Fabric
• ServerStats Version: 1.2.7

[BUG] Website is not reachable

Describe the bug
Wanted to see the documentation, but the website seems to be down

To Reproduce
Steps to reproduce the behavior:

1. Go to https://serverstats.diced.tech/

Expected behavior
The website should be working

[BUG] No newline at the end of prometheus output

Prometheus metric format description says that "last line must end with a line feed character". However, ServerStats intentionally skips the last newline for some reason. This blocks me from using the plugin, because the metric collector I use cannot parse the response without this \n at the end.

The documentation website cannot be opened

Describe the bug
Seems like the docs website is down? Is it possible to access the docs from a readme file in the meantime?

To Reproduce
Steps to reproduce the behavior:

1. Go to serverstats.diced.me
2. You'll get a blank page and redirected to 1redirb.com

[BUG] Graphs stop updating

After some time of running the server (usually over a day) the graph in Grafana stops updating. It just becomes a flat line without any updates from the serverstats plugin. /stats get still returns the correct information though.

[BUG] - Certain stats not loading on paper server

Describe the bug
Paper server missing stats (entity-count, loaded-chunks, mspt, packets & tps)

To Reproduce
Steps to reproduce the behavior:

1. Launch server with git-Paper-353 (most recent 1.17 build)
2. Install ProtocolLib v4.7.0 (Latest)
3. Install ServerStats-Bikkit v1.2.7
4. Start Server & browse to :8000
5. Stats are displayed but missing certain metrics

Expected behavior
I am expecting to see all stats enabled in plugin config

Screenshots
metrics export:

# HELP player_count
# TYPE player_count gauge
player_count 0
# HELP cpu
# TYPE cpu gauge
cpu 0.854305
# HELP uptime
# TYPE uptime gauge
uptime 120622
# HELP threads
# TYPE threads gauge
threads 126.000000
# HELP gc
# TYPE gc summary
gc{name="G1 Old Generation"} 0
gc{name="G1 Young Generation"} 311
# HELP free_memory
# TYPE free_memory gauge
free_memory 429285784
# HELP total_memory
# TYPE total_memory gauge
total_memory 773849088
# HELP max_memory
# TYPE max_memory gauge
max_memory 4194304000

Noticed this in my log:

[17:31:54 INFO]: [ServerStats] Enabling ServerStats v1.2.7
[17:31:55 INFO]: [ServerStats] Enabling Packet Metrics since ProtocolLib exists
[17:31:55 WARN]: [ProtocolLib] [PacketFilterManager] [ServerStats] Unsupported server packet in current Minecraft version: UPDATE_ENTITY_NBT[PLAY, SERVER, 253, classNames: [net.minecraft.network.protocol.game.PacketPlayOutUpdateEntityNBT, net.minecraft.network.protocol.game.ClientboundUpdateEntityNBTPacket] (unregistered)]
[17:31:55 WARN]: [ProtocolLib] [PacketFilterManager] [ServerStats] Unsupported server packet in current Minecraft version: SET_COMPRESSION[PLAY, SERVER, 254, classNames: [net.minecraft.network.protocol.game.PacketPlayOutSetCompression, net.minecraft.network.protocol.game.ClientboundSetCompressionPacket] (unregistered)]
[17:31:55 WARN]: [ProtocolLib] [PacketFilterManager] [ServerStats] Unsupported server packet in current Minecraft version: MAP_CHUNK_BULK[PLAY, SERVER, 255, classNames: [net.minecraft.network.protocol.game.PacketPlayOutMapChunkBulk, net.minecraft.network.protocol.game.ClientboundMapChunkBulkPacket] (unregistered)]
[17:31:55 WARN]: [ProtocolLib] [PacketFilterManager] [ServerStats] Unsupported server packet in current Minecraft version: WORLD_BORDER[PLAY, SERVER, 248, classNames: [net.minecraft.network.protocol.game.PacketPlayOutWorldBorder, net.minecraft.network.protocol.game.ClientboundWorldBorderPacket] (unregistered)]
[17:31:55 WARN]: [ProtocolLib] [PacketFilterManager] [ServerStats] Unsupported server packet in current Minecraft version: TITLE[PLAY, SERVER, 249, classNames: [net.minecraft.network.protocol.game.PacketPlayOutTitle, net.minecraft.network.protocol.game.ClientboundTitlePacket] (unregistered)]
[17:31:55 WARN]: [ProtocolLib] [PacketFilterManager] [ServerStats] Unsupported server packet in current Minecraft version: SPAWN_ENTITY_WEATHER[PLAY, SERVER, 250, classNames: [net.minecraft.network.protocol.game.PacketPlayOutSpawnEntityWeather, net.minecraft.network.protocol.game.ClientboundSpawnEntityWeatherPacket, net.minecraft.network.play.server.SPacketSpawnGlobalEntity] (unregistered)]
[17:31:55 WARN]: [ProtocolLib] [PacketFilterManager] [ServerStats] Unsupported server packet in current Minecraft version: BED[PLAY, SERVER, 251, classNames: [net.minecraft.network.protocol.game.PacketPlayOutBed, net.minecraft.network.protocol.game.ClientboundBedPacket, net.minecraft.network.play.server.SPacketUseBed] (unregistered)]
[17:31:55 WARN]: [ProtocolLib] [PacketFilterManager] [ServerStats] Unsupported server packet in current Minecraft version: ENTITY[PLAY, SERVER, 245, classNames: [net.minecraft.network.protocol.game.PacketPlayOutEntity, net.minecraft.network.protocol.game.ClientboundEntityPacket, net.minecraft.network.play.server.SPacketEntity] (unregistered)]
[17:31:55 WARN]: [ProtocolLib] [PacketFilterManager] [ServerStats] Unsupported server packet in current Minecraft version: TRANSACTION[PLAY, SERVER, 246, classNames: [net.minecraft.network.protocol.game.PacketPlayOutTransaction, net.minecraft.network.protocol.game.ClientboundTransactionPacket, net.minecraft.network.play.server.SPacketConfirmTransaction] (unregistered)]
[17:31:55 WARN]: [ProtocolLib] [PacketFilterManager] [ServerStats] Unsupported server packet in current Minecraft version: COMBAT_EVENT[PLAY, SERVER, 247, classNames: [net.minecraft.network.protocol.game.PacketPlayOutCombatEvent, net.minecraft.network.protocol.game.ClientboundCombatEventPacket] (unregistered)]
[17:31:55 WARN]: [ProtocolLib] [PacketFilterManager] [ServerStats] Unsupported client packet in current Minecraft version: FLYING[PLAY, CLIENT, 254, classNames: [net.minecraft.network.protocol.game.PacketPlayInFlying, net.minecraft.network.protocol.game.ServerboundFlyingPacket, net.minecraft.network.play.client.CPacketPlayer] (unregistered)]
[17:31:55 WARN]: [ProtocolLib] [PacketFilterManager] [ServerStats] Unsupported client packet in current Minecraft version: TRANSACTION[PLAY, CLIENT, 255, classNames: [net.minecraft.network.protocol.game.PacketPlayInTransaction, net.minecraft.network.protocol.game.ServerboundTransactionPacket, net.minecraft.network.play.client.CPacketConfirmTransaction] (unregistered)]
[17:31:55 WARN]: [ProtocolLib] [PacketFilterManager] [ServerStats] Unsupported server packet in current Minecraft version: UPDATE_ENTITY_NBT[PLAY, SERVER, 253, classNames: [net.minecraft.network.protocol.game.PacketPlayOutUpdateEntityNBT, net.minecraft.network.protocol.game.ClientboundUpdateEntityNBTPacket] (unregistered)]
[17:31:55 WARN]: [ProtocolLib] [PacketFilterManager] [ServerStats] Unsupported server packet in current Minecraft version: SET_COMPRESSION[PLAY, SERVER, 254, classNames: [net.minecraft.network.protocol.game.PacketPlayOutSetCompression, net.minecraft.network.protocol.game.ClientboundSetCompressionPacket] (unregistered)]
[17:31:55 WARN]: [ProtocolLib] [PacketFilterManager] [ServerStats] Unsupported server packet in current Minecraft version: MAP_CHUNK_BULK[PLAY, SERVER, 255, classNames: [net.minecraft.network.protocol.game.PacketPlayOutMapChunkBulk, net.minecraft.network.protocol.game.ClientboundMapChunkBulkPacket] (unregistered)]
[17:31:55 WARN]: [ProtocolLib] [PacketFilterManager] [ServerStats] Unsupported server packet in current Minecraft version: WORLD_BORDER[PLAY, SERVER, 248, classNames: [net.minecraft.network.protocol.game.PacketPlayOutWorldBorder, net.minecraft.network.protocol.game.ClientboundWorldBorderPacket] (unregistered)]
[17:31:55 WARN]: [ProtocolLib] [PacketFilterManager] [ServerStats] Unsupported server packet in current Minecraft version: TITLE[PLAY, SERVER, 249, classNames: [net.minecraft.network.protocol.game.PacketPlayOutTitle, net.minecraft.network.protocol.game.ClientboundTitlePacket] (unregistered)]
[17:31:55 WARN]: [ProtocolLib] [PacketFilterManager] [ServerStats] Unsupported server packet in current Minecraft version: SPAWN_ENTITY_WEATHER[PLAY, SERVER, 250, classNames: [net.minecraft.network.protocol.game.PacketPlayOutSpawnEntityWeather, net.minecraft.network.protocol.game.ClientboundSpawnEntityWeatherPacket, net.minecraft.network.play.server.SPacketSpawnGlobalEntity] (unregistered)]
[17:31:55 WARN]: [ProtocolLib] [PacketFilterManager] [ServerStats] Unsupported server packet in current Minecraft version: BED[PLAY, SERVER, 251, classNames: [net.minecraft.network.protocol.game.PacketPlayOutBed, net.minecraft.network.protocol.game.ClientboundBedPacket, net.minecraft.network.play.server.SPacketUseBed] (unregistered)]
[17:31:55 WARN]: [ProtocolLib] [PacketFilterManager] [ServerStats] Unsupported server packet in current Minecraft version: ENTITY[PLAY, SERVER, 245, classNames: [net.minecraft.network.protocol.game.PacketPlayOutEntity, net.minecraft.network.protocol.game.ClientboundEntityPacket, net.minecraft.network.play.server.SPacketEntity] (unregistered)]
[17:31:55 WARN]: [ProtocolLib] [PacketFilterManager] [ServerStats] Unsupported server packet in current Minecraft version: TRANSACTION[PLAY, SERVER, 246, classNames: [net.minecraft.network.protocol.game.PacketPlayOutTransaction, net.minecraft.network.protocol.game.ClientboundTransactionPacket, net.minecraft.network.play.server.SPacketConfirmTransaction] (unregistered)]
[17:31:55 WARN]: [ProtocolLib] [PacketFilterManager] [ServerStats] Unsupported server packet in current Minecraft version: COMBAT_EVENT[PLAY, SERVER, 247, classNames: [net.minecraft.network.protocol.game.PacketPlayOutCombatEvent, net.minecraft.network.protocol.game.ClientboundCombatEventPacket] (unregistered)]
[17:31:55 WARN]: [ProtocolLib] [PacketFilterManager] [ServerStats] Unsupported client packet in current Minecraft version: FLYING[PLAY, CLIENT, 254, classNames: [net.minecraft.network.protocol.game.PacketPlayInFlying, net.minecraft.network.protocol.game.ServerboundFlyingPacket, net.minecraft.network.play.client.CPacketPlayer] (unregistered)]
[17:31:55 WARN]: [ProtocolLib] [PacketFilterManager] [ServerStats] Unsupported client packet in current Minecraft version: TRANSACTION[PLAY, CLIENT, 255, classNames: [net.minecraft.network.protocol.game.PacketPlayInTransaction, net.minecraft.network.protocol.game.ServerboundTransactionPacket, net.minecraft.network.play.client.CPacketConfirmTransaction] (unregistered)]
[17:31:55 INFO]: [ServerStats] Starting ServerStats-Worker tasks

Please complete the following information):

• OS: Linux (Docker via Pterodactyl)
• Server Software: Paper (1.17 git-Paper-353)
• ServerStats Version: 1.2.7

Additional context
ServerStats.conf:

interval=15000
logs {
    write-log="Wrote stats"
    write-logs=false
}
pushable {
    cpu=true
    disk-space=true
    entity-count=true
    free-memory=true
    gc=true
    loaded-chunks=true
    max-memory=true
    mspt=true
    packets=true
    player-count=true
    threads=true
    total-memory=true
    tps=true
    uptime=true
}
web-server {
    hostname="0.0.0.0"
    port=8000
    route="/metrics"
}

plugins enabled:

AureliumSkills, BetterSleeping4, CoreProtect, DeluxeMenus, DiscordSRV, dynmap, Essentials, EssentialsAntiBuild, EssentialsChat, EssentialsProtect, floodgate, HoloMobHealth, ItemJoin, ItemSorters, LuckPerms, PlaceholderAPI, PlaceholderSIGN, ProtocolLib, ServerListMotdSpigot, ServerStats, SudoSigns, TileDataSaver, Vault, VeinMiner, ViaBackwards, ViaVersion, VillagerSaver

[BUG] ServerStats not sending some data

Describe the bug
I just installed ServerStats as Bukkit plugin and enable all metrics in config but i not get some data (tps, mspt, disk-space, entity-count, loaded-chunks and packets)

To Reproduce
Steps to reproduce the behavior:

1. Go to https://ci.codemc.io/job/Spottedleaf/job/Tuinity-1.17/lastSuccessfulBuild/artifact/
2. Download Tuinity
3. Just start server with plugin
4. See error

Please complete the following information):

• OS: Linux 4.19.0-16-amd64
• Server Software: Tuinity (git-Tuinity-23)
• ServerStats Version: 1.2.7

Additional context

# HELP player_count
# TYPE player_count gauge
player_count 0
# HELP cpu
# TYPE cpu gauge
cpu 54,747836
# HELP uptime
# TYPE uptime gauge
uptime 31242
# HELP threads
# TYPE threads gauge
threads 53,000000
# HELP gc
# TYPE gc summary
gc{name="G1 Old Generation"} 0
gc{name="G1 Young Generation"} 603
# HELP free_memory
# TYPE free_memory gauge
free_memory 279578944
# HELP total_memory
# TYPE total_memory gauge
total_memory 959447040
# HELP max_memory
# TYPE max_memory gauge
max_memory 1862270976

Btw also tested not on production server (Windows 11 64 bit) also not working