dianaayoub / hyf_javascript3 Goto Github PK

Regarding this line:

console.log(myMovie.getStars().map(actor => ${actor.getName()} ${actor.getRole()} ${actor.getAge()}));

Perhaps consider adding some spacing and punctuation so that the generated result is clearer.

Hi Diana, here is my feedback on your homework.

1. Your repo is missing an .eslintrc.json file. Because of this ESLint is not checking you code. See VSCode Tips or the message I posted on slack on 6 Feb.
2. In line 50, you forgot to declare the loop variable i. This error goes unnoticed when you run the code because you are not testing the getAverageRating() method. However as soon as you do you get a runtime error:

   /Users/jimcramer/hackyourfuture/class13/js3/diana/oop2.js:50
       for (i of this.ratings) {
            ^
   
   ReferenceError: i is not defined
   

   ESLint would have flagged this with a warning in VSCode.
3. It would have been nice if you had added some code to test the getAverageRating() method, e.g.:

   myMovie.addRating(8);
   myMovie.addRating(7);
   console.log(myMovie.getAverageRating());
   

4. In the assignment it was asked to get the director's name like this: director.getName(). This hints that the director was supposed to be a StaffMember object rather than just a string.
5. You getAge() method assumes the current date is always 2018. Your code will no longer be accurate in 2019 and beyond. Maybe you can research how you can get the actual current year. Look up the documentation for the JavaScript Date object.