dianaayoub / hyf-javascript2. Goto Github PK

@DianaAyoub
First off everything works just fine and I'm getting the right results :)
and your code looks nice and props on the indentation (y).

Hi Diana, here is my feedback on your homework.

It looks like you copied some bits from other people. Apologies if I'm wrong, but I prefer that you just leave out the bits you couldn't do and state the reason why.

I got a run-time error when I try to run homework.js in node:

/Users/jimcramer/hackyourfuture/class13/js2/week3/diana/week3/homework.js:32
        console.log("this number( " + a + " )is not divisible by 5 ");
                                      ^

ReferenceError: a is not defined

Did you get this error too? I fixed this by replacing a by item.

Next, you are missing an .eslintrc.json file in your repo. Check the VSCodeTips on how to get one.

Step 4.1

I think you missed the point here about passing a function to another function as a parameter. Hopefully last lecture made this more clear. But you were supposed to call the foo function like this without parentheses for bar:

foo(bar);

The code then becomes simply:

function foo(callback) {
    callback();
}

function bar() {
    console.log('Hello, I am bar!');
}
foo(bar);

Step 4.2

I see strong similarity with the code of Fadi. For the homework it is important that you go through the process of creating your own code. That's how you learn. I'm not interested in somebody else's solution. I already reviewed that. I prefer that you just say: I couldn't do it, I was sick or whatever the reason. Apologies if I'm wrong and Fadi actually copied your code instead the other way around.

Look at my review of his work here.

Step 4.3.1

I can take out this redundant line of code without affecting the result:

    // str = num < 0 ? "" : str;

Step 4.3.2

Same

Step 4.3.3

Same

Step 4.4

Missing

Step 4.5

Missing

Step 4.7

I don't see the output of multiplyAll because the console.log statement is unreachable because it comes after the return statement. If you had an eslint statement in your repo folder, you would have got a warning about this.

Step 5

This looks like a copy of Kenan's homework, including the same errors he made. Please don't copy.

Here is my review of Kenan's homework.