dhleong / wish Goto Github PK

So other people can view it

IE the things added in #39

There's no need for data source functions to have access to this, and limiting them to only being able to manipulate input data and preventing them from somehow causing side-effects sounds like a smart security feature.

EG: Monk and Barbarian Unarmored Defense should only apply when not wearing armor

Also, it'd be nice if we could preview the save value would be in the spell-card widget

Should we just put it on the Race?

Especially ones which consume limited-uses, eg: Dragonborn's Breath Weapon.

Probably something is not extern'd properly

This means promoting the ::total-level subscription to a builtin. That the level to use for scaling with races should be the total of class levels is D&D-specific, but it seems reasonable to assume that as a default....

Semantically it's a bit yuck, but worth it

Ring of Spell Storing, for example, would really benefit

In particular, some Warlock Eldritch Invocations make certain spells at-well, and sometimes "at will" but once-per-day. Also, Tiefling's Infernal Legacy lets them cast Hellish Rebuke as a 2nd level spell once per long-rest. DNDB handles this by being able to render the spell twice under 2nd level spells, based on the source—once from Infernal Legacy, and once when upcast from 1st level as a Warlock.

I'm not sure what the best way for us to surface these things is yet....

Supposedly faster and smaller than edn for large payloads. May be an interesting choice for data sources

The "manage prepared" overlay is including all wizard spells, instead of just those from the spellbook. Just in my test character, though; not my first Wizard. Doesn't seem to be related to whether Wizard is :primary?, or part of a multiclass at all.

For example, the Bard's Magic Secrets and Lore Bard's Additional Magical Secrets

Whenever we have them all, I suspect this will be important for perf reasons

We always want to preventDefault on the event

Also, probably, other conditions

Also, properly handle a fixed list of extra spells

Can probably use the :buffs attr

We should be able to just provide a const amount based on level, and/or replace the value using level-scaling. Right now none of the function uses of :max-options actually work for D&D5e

For example, Barbarians can start with a Greataxe or any martial melee weapon. If we just do :ranged? false, however, nothing will match since melee weapons just omit the :ranged? key.

In particular:

• Add more spell info
• Reflect "always prepared" spells in the extra-spells list
• Filter out spells that are too high-level
• "Disable" preparing more spells than should be legal (but probably just a visual treatment rather than outright forbidding, for homebrew purposes)
• Shared "spell info card" widget with all the bits and pieces

All the values for Draconic Ancestor from Sorcerer, for example, show up; you should only see what you've selected, and not all of the other options. The quick hack fix is to mark them all as :implicit?, but I think actually you would like to see which one you've selected in this case (at least, if we add better descriptions).

Missing the /wish prefix