dharple / detox-php Goto Github PK

Unit tests that work on PHP 7.4.x are breaking on PHP 8.0.1, despite iconv being the same, and the internals showing the same values for ICONV_IMPL (glibc) and ICONV_VERSION (2.31):

1) Outsanity\Detox\Tests\Filter\AsciiTest::testBasicTransliteration
Ascii filter failed.  Encoding is set to: UTF-8
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Slainte'
+'Sl?inte'

It happens during character-by-character conversion.

As a developer, I'd like to have unit tests using data providers, so I can tell if I have more than one problem with my unit tests per run.

The Greek and Braille examples provided by w3 https://www.w3.org/2001/06/utf-8-test/UTF-8-demo.html don't transliterate, but they should. Just searching on "transliteration" on Google gives a clear example of transliterating Greek text. Work around it, or work with iconv to fix it.