dgets / gensync Goto Github PK

As was left off the last time this was being worked on, there is a problem in the current command-line assembly code. It is causing the following error: Missing trailing-' in remote-shell command.

The only place that the single ticks are used in the command line that is assembled is in the specification for ssh to find the secret keyring in a manually specified file. While it would not be a permanent fix, it may be possible to temporarily work around by using one that will be checked by default, or specifying in an ssh config file.

Code that assembles the command line follows:

RSYNC_FULL="$RSYNC $RSYNC_VERBOSE_OPTS --chmod=$RSYNC_CHMOD_OPTS "
RSYNC_FULL="${RSYNC_FULL}-e 'ssh -y -p 22 -i \"/sbbs/.ssh/id_rsa\"' "
RSYNC_FULL="${RSYNC_FULL}/sbbs ${RMTACCT}@${RMTHST}:${RMTHSTDIR}"

None of the expanded bits hold any internally single or double quoted strings.

It would be good at some point to supplement this shell scripting with some other work that would be able to pull SQL dumps and other vital /var information that is updated on a daily basis, as well. It's hardly going to be the first thing on the plate here; replicating the filesystem (at this point for my BBS, but also configurable and expandable) is definitely the priority. In the future, though, this could be a great script to work with a bunch of different subsystems.