deyemiobaa / leaderboard

The leaderboard website displays scores submitted by different players. It also allows you to submit your score. All data is preserved thanks to the external Leaderboard API service.

• 👋 Hi, I’m Sodiq, a full-stack software engineer
• 👀 I build functional and human-centered solutions for the web
• 📫 How to reach me: @deyemiobaa on twitter or send an email

leaderboard's Issues

Peer-Peer Code Review

Hi @deyemiobaa, great job on the leaderboard. 🥳 Special shout out for the minimalist but great-looking design. 👏

A few issues that we noticed during the peer code review session that might make the project even better are the following:

• You have added a nice feature to notify the user that the score has been added by displaying the prompt on the span inside the form. However, the prompt is not appearing after a user adds the score. You could add display: inline in the span CSS rule to fix that little issue.
• Your leaderboard is correctly displaying the user scores but currently, the order of the scores is not sequential. It might be a good idea to add a sort function inside the loadScores function before populating the list.
• Your form currently allows for negative scores, which is not a big issue. However, it might be a good idea to add a min=0 attribute in your input to prevent users from adding negative numbers.

Apart from those little fixes, everything else is great. Keep up the good work 👊

Peer-to-peer review

Hi Sodiq 👋

Congratulation on the great work you did 🎊
You did well implementing the project and congratulations on making all the requirements and meeting deadlines.
Now you can just try to make it looks nice with some styles 😊

Besides that, great work, and congrats
Wish you all the best and happy coding 😃