The carousell-telebot from dexterleng

carousell-telebot's People

Contributors

Stargazers

Watchers

carousell-telebot's Issues

Simplifying parenthesis matching algorithm

https://github.com/dexterleng/carousell-telebot/blob/master/carousell_query.py#L54

I think you can simplify this to a counter based approach?

OPEN_BRACE = "{"
CLOSE_BRACE = "}"


def find_matching_parenthesis(string, start_index):

    assert(string[start_index] is OPEN_BRACE)

    counter = 1
    for index, char in enumerate(string[start_index+1:]):
        if char is OPEN_BRACE:
            counter += 1
        elif char is CLOSE_BRACE:
            counter -= 1
        if not counter:
            return start_index + index + 1

    raise ValueError("Matching parenthesis not found")

Not sure if I'm missing any edge cases here. Would be good to add some unit tests especially for utility functions like this.

You also probably wrap this around a try/catch to make it a bit more robust:

https://github.com/dexterleng/carousell-telebot/blob/master/carousell_query.py#L51

json.loads will raise an exception (and crash the bot) if the string provided is not valid JSON.

Recommend Projects