libxdg-basedir src/basedir.c memset() emulation fatally broken about libxdg-basedir

[devnev]

Wow... I don't even... blarg?

[tweerwag]

Just look at the code more carefully. It clears memory until n wraps around and becomes negative... You probably want something like

static void xdgZeroMemory(void* p, int n)
{
    for (; n > 0; n--)
        ((char*)p)[n] = 0;
}

[ILMostro]

I doubt this is legit; i.e. not what people expect to be like the libxdg-basedir from n.ethz.ch... Though, I wish it was

[tweerwag]

Huh? What are you referring to with this? This issue? My suggestion? This whole repository?

[davmac314]

@tweerwag your suggested fix is incorrect. Consider the simple case of xdgZeroMemory(p, 1) - it should only set p[0] = 0, instead it will set p[1] = 0 (and will not set p[0] = 0). I have a correct fix in my fork.

[tweerwag]

Oops... Good to hear someone is picking up maintaining!

[ILMostro]

Yeah, sorry for the noise there. IIRC, I had been trying to find a recent version of the codebase and wasn't sure if this repo was dead, active, separate from the original... Thank you