devicehive / devicehive-android Goto Github PK

I think I found a bug when device is trying to register.
When device registers returns status code 204, from documentation for RESTful protocol 1.3.1 -
"204 No Content: Requested operation completed successfully and there is no resource in the response body (typically for DELETE operations)."
So according to this i think that code 204 is successful status code and need to be in isSuccessStatusCode(int statusCode) in network/NetworkCommand.java. So on line 171

FROM:
protected boolean isSuccessStatusCode(int statusCode) {
return statusCode == 200 || statusCode == 201;
}

TO:
protected boolean isSuccessStatusCode(int statusCode) {
return statusCode == 200 || statusCode == 201 || statusCode == 204;
}

When the code is 204 and it has no resources in the body, an exception is raised, because responce.getEntity() returns null and toString cannot parse it. So on line 209 I suggest

FROM:
String responceString = EntityUtils.toString(responce.getEntity());

TO:
try {
responceString = EntityUtils.toString(responce.getEntity());
} catch (IllegalArgumentException iae) {
responceString = "";
}

Please look at this bug, and if it is real bug please fix it.

When trying to get deviceId from with

GetDeviceEquipmentStateCommand.getDeviceId(resultBundle), an error is returned that states that expected result was String, but it got Parcelable instead.

The simple fix is to make a change in the following line:

GetDeviceEquipmentStateCommand: 96

from getParcelable(...) to get String().