deviangularjs / 4235opensource Goto Github PK

What steps will reproduce the problem?
1. click the SearMark's clickable icon right next to Chrome's Omnibox.
2. input key word you want to search, for example, "Java".
3. click "Search in History" button.
4. in the new pop-up page, you can only get the history records within one week.

What is the expected output? What do you see instead?
I need to get the results within two weeks. 

Please use labels and text to provide additional information.

What steps will reproduce the problem?
chrome-extension://fegdedpkalmiaccnicdilpdlnainbaee/SearchMarkUI.html 

What is the expected output? What do you see instead?
it should be not fixed. 

Please use labels and text to provide additional information.

What steps will reproduce the problem?
1. revise something and git commit
2. then run git push origin master

What is the expected output? What do you see instead?

expected output: revise successfully
actually see: failed

Please use labels and text to provide additional information.

Branch name:
44696e937f64

When reviewing my code changes, please focus on:
The part which implements how to show results

Branch name: master

Purpose of code changes on this branch: change manifest version from  1.0 to 2.0


When reviewing my code changes, please focus on:
SearchMarkUI.js, background.js, manifest.json files. 

After the review, I'll merge this branch into:
/trunk

What steps will reproduce the problem?
1. click the SearMark's clickable icon right next to Chrome's Omnibox. 
2. input key word you want to search, for example, "Java". 
3. click "Search in Bookmark" button.
4. the voice will tell how much time you spend, but it will not speak out how 
much items are searched.

What is the expected output? What do you see instead?
users should hear the voice of how many entries they can get. 

Please use labels and text to provide additional information.

What steps will reproduce the problem?
1. open extension management page
2. press the reload extension link
3. all the data including bookmark and history will be reload to database even 
if there is no changes for them

What is the expected output? What do you see instead?
if there is no changes for them, reloading will not happen. 

Please use labels and text to provide additional information.

What steps will reproduce the problem?
1. Click the extension icon.
2. Enter a keyword and use bookmark search.
3. Click the extension icon again. So there will be a new tab opened.
4. Enter a keyword and use history search.

What is the expected output? What do you see instead?
The expected output should be the search in history results should be only 
showed in the second page. But it also appended to the first result page. 

Please use labels and text to provide additional information.

What steps will reproduce the problem?
1. click the SearMark's clickable icon right next to Chrome's Omnibox. 
2. input key word you want to search, for example, "Java". 
3. click "Search in Bookmark" button.
4. in the new pop-up page, you can not search anymore. 

What is the expected output? What do you see instead?
you can search the result in the new pop-up page

What steps will reproduce the problem?
1. click the SearMark's clickable icon right next to Chrome's Omnibox. 
2. input key word you want to search, for example, "Java". 
3. click "Search in Bookmark" button.
4. when you wait for the results or no result returned, no friendly message to 
tell you that. 

What is the expected output? What do you see instead?
when you are waiting for the results, the page should show message. 
when there is no results returned, the page should also prompt friendly message.

Please use labels and text to provide additional information.

Branch name:
44696e937f64
Purpose of code changes on this branch:
How to fix the bug below?

When reviewing my code changes, please focus on:
The part of adding history data.

When log into a website by entering password (e.g. a bank's website), the 
extension can interfere the normal operation. If the bank's website detect some 
program is trying to record the url, it will forbidden the user to log in.  

What steps will reproduce the problem?
 relevance adjust will duplicated "*-Bookmark Search" 


What is the expected output? What do you see instead?
Only one "-Bookmark Search" downside the dropdown 

The bug I mentioned before is even more serious. Even I disabled the extension, 
I still cannot log into any password required website. Before we implement the 
function of storing user preference, it did not happen. 

Thanks,
Yannick Yangchen Pan

What steps will reproduce the problem?
1. click the SearMark's clickable icon right next to Chrome's Omnibox. 
2. input key word you want to search, for example, "Java".
3. click "Search in History" button.
4. in the new pop-up page, there is no Links for some results .
What is the expected output? What do you see instead?
same format for search results, filter the results which have no links.

Please use labels and text to provide additional information.