devcloudfe / react-devui Goto Github PK

⭐ Suggestion

📃 Motivating Example

💻 Use Cases

⭐ Suggestion

Button组件，当dType设置为link时，建议渲染为一个a标签，而不是button标签。

PR模板的任务列表格式错误，缺失-

不确定是否提供该组件
实现：overflow: hidden + resize event
效果如下

Make sure to read README before development.
开发之前确保阅读了 README。

Some components are not considered for implementation for the time being, because we want the number of components in the component library to be as small as possible, and some components can be implemented through expansion or combination.
某些组件暂时不考虑实现，因为我们希望组件库的组件数量尽可能的少，可以通过拓展或者组合的方式实现某些组件。

Component development can refer to:
组件开发可参考：

• devui
• antd
• mui

Be sure to confirm Props with me before developing components. Only after confirming Props, the component is considered to be under development!
开发组件前务必和我确认Props。只有确认过Props，才认为组件是在开发中！

Notice! ! ! According to the progress of the project, I will complete some components that are not under development by myself.
注意！！！依据项目进展，某些还没开发中的组件我会自己完成。

The following is a list of components that have been confirmed for development:
下面是已确认开发的组件列表：

General | 通用

• Button 按钮 @xiejay97
• Compose 组合 @xiejay97

Layout | 布局

• Affix 固钉 @xiejay97
• BackTop 回到顶部 @c0dedance
• Grid 栅格 @xiejay97
• Separator 分隔符 @xiejay97
• Splitter 分割器 待认领

Navigation | 导航

• Anchor 锚点 @xiejay97
• Dropdown 下拉菜单 @xiejay97
• Menu 导航菜单 @xiejay97
• Pagination 分页 @xiejay97
• Tabs 页签面板 @xiejay97

Data Display | 数据展示

• Avatar 头像 @zxlfly
• Badge 徽章 @AlanLee97
• Card 卡片 @c0dedance
• Carousel 走马灯 @aouos
• Collapse 折叠面板 @Kiki-Q
• Comment 评论 @GeorgeLeoo
• Empty 空状态 @xiejay97
• Progress 进度条 @pineapple0919
• Skeleton 骨架屏 待认领
• Table 表格 待认领
• Tag 标签 @xiejay97
• Timeline 时间轴 @kevinawe
• Tooltip 文字提示 @xiejay97
• Tree View 树视图 @NidusP

Data Entry | 数据录入

• AutoComplete 自动完成 @zxlfly
• Cascader 级联选择 @xiaoboRao
• Checkbox 多选框 @xiejay97
• DatePicker 日期选择器（参考DatePickerPro） 待认领
• Form 表单 @xiejay97
• EditableSelect 可输入下拉框 待认领
• Input 输入框 @xiejay97
• InputNumber 数字输入框 待认领
• MultiAutoComplete 多项自动完成 @zxlfly
• Radio 单选组
• Rate 评分 @pineapple0919
• Select 选择器 @xiejay97
• Slider 滑动输入条 @tjw-javen
• Switch 开关 @big-bomp
• Textarea 文本域 @xiejay97
• TimePicker 时间选择器 待认领
• Transfer 穿梭框 @git-Where
• TreeSelect 树形选择器 待认领
• Upload上传 @zxlfly

Feedback | 反馈

• Alert 警告提示 @c0dedance
• Drawer 抽屉 @xiejay97
• Loading 加载中 @huanganfree
• Modal 对话框 @SleepDevil
• Notification 通知 @xiejay97
• Popover 悬浮提示 @SleepDevil
• Toast 提示 @xiejay97

🙁 Actual behavior

    console.log(header.find(DButton).length)
    expect(header.find(DButton).length).toBe(0);  // 1

单测时不添加dCloseIcon时不应添加关闭按钮，但预期添加了

🙂 Expected behavior

  const header = shallow(<DHeader/>)
  console.log(header.find(DButton).length)
  expect(header.find(DButton).length).toBe(0); 

⏯ Steps to Reproduce

🕗 Version & Environment

🙁 Actual behavior

tools\base64-data.ts的27行：

table.write([filePath.match(/(?<=packages\/)[\s\S]+?(?=\/)/)![0], file]);

[filePath.match(/(?<=packages\/)[\s\S]+?(?=\/)/)可能为null，导致报错。

报错信息如下所示：

🙂 Expected behavior

能够正常运行

⏯ Steps to Reproduce

执行以下命令：

yarn serve:site

🕗 Version & Environment

os: windows 11
node: v16.19.0
yarn: 1.22.19

因我个人需要维护其它项目，所以需要有意愿维护该项目的开源伙伴！

我会在周五给到选择，主要参考github公开的一些信息，如果想提供其它信息或者交流，邮件即可。

mount not currently supported React18
I read that the 'enzyme-adapter-react-16.3' is also used ReactDOM.render

Warning: ReactDOM.render is no longer supported in React 18. Use createRoot instead. 
Until you switch to the new API, your app will behave as if it's running React 17.

⭐ Remove the "D" prefix in component names

Thrilled to see Huawei has open-source projects in the frontend field.

One thing that is confusing is why we have a prefix "D" in all our components?

If I am an end developer user and as the author of some codebase, my future codebase reader can be confused with

1. what is "D" there?
2. Also, the "D" doesn't convey any meaning at all
3. it is a mental burden to developers.

📃 Motivating Example

My concerns arise from reading Clean Code, at the first chapter, Avoid Encodings.

🙁 Actual behavior

在项目根目录下执行命令：yarn site:serve，会报以下错误：

ERROR in packages/ui/src/components/form/FormItem.tsx:12:10
TS2305: Module '"./Form"' has no exported member 'DFormContext'.
    10 | import { DTooltip } from '../tooltip';
    11 | import { DError } from './Error';
  > 12 | import { DFormContext } from './Form';
       |          ^^^^^^^^^^^^
    13 | import { DFormGroupContext } from './FormGroup';
    14 | import { Validators } from './form';
    15 |

出现这个问题的原因是 Form 组件目录下有两个文件名相似，只是大小写不一样，这在 macOS 操作系统下会出问题。

命名冲突的文件：

• form.ts
• Form.tsx

🙂 Expected behavior

期望执行yarn site:serve命令能正常本地启动网站，不要报错。

⏯ Steps to Reproduce

在项目根目录下执行命令：yarn site:serve

🕗 Version & Environment

• 分支：main
• 操作系统：macOS Monterey 12.2

https://www.w3.org/WAI/ARIA/apg/

⭐ Suggestion

为了保持React DevUI符合DevUI设计规范，建议引用同一份样式变量文件。

Ng DevUI设计规范样式变量文件：
https://github.com/DevCloudFE/ng-devui/blob/master/devui/style/devui.scss

📃 Motivating Example

💻 Use Cases

⭐ Suggestion

📃 Motivating Example

💻 Use Cases