descended / maplestorydiscbot Goto Github PK

Suggestion:
Add a version checking feature, such that on startup, the bot checks against the GitHub repo to see if there are any new updates

It seems that ports are locked at the defaulted 3306 given by mysql-connector. This could cause problems for user who have more than one database active on multiple ports, or user who simply don't use 3306

Suggestion:

• Add a port parameter for every function that is used and add a PORT constant in the config.py file

In the on_ready event of the discord bot. The get_online_players() scheduler is never awaited, which would cause problems if the feature was ever enabled.

Suggestion :

• Add await get_online_players().start() where appropriate

Setting up the Web API

After resolving dependencies, create a new folder in the source code for the API-related files

"create a new folder"
Can it be any folder in any depth? Does it have to be root? Does it need to be named a certain way?

Download the proprietary API functions from this page (or make your own)

What does one do with that file? Just put it into the folder and it will automatically work?