Coder Social home page Coder Social logo

distribution's People

Contributors

antonmedv avatar barryvdh avatar benoitchantre avatar garak avatar schmengler avatar seldaek avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

distribution's Issues

What about vendoring symfony into deployer?

Now we have 3 types of installing deployer. What about vendoring symfony packages inside deployer repo?

No deps in deployer/deployer package, and symfony under src/Vendor/Symfony.

What do you think?

Useless files are distributed

After installing this package via composer, I see the following files in vendor/deplyer/dist directory:

composer.json dep .gitignore README.md update

The only file that we actually need is dep.
Other files should be removed (added to "export-ignore" in .gitattributes?)

Deployer ignores overriden default deploy task commands

Upgrade without issues from v6.8 to v7.0.0-rc.4 with PHP 8.1.3 but I've noticed that the following snippet:

// Main
task('deploy', [
    'deploy:info',
    'deploy:prepare',
    'deploy:lock',
    'deploy:release',
    'deploy:update_code',
    'deploy:unlock',
    'deploy:shared',
    'deploy:vendors',
    'deploy:symlink',
    'typo3:finish',
    'deploy:unlock',
    'deploy:cleanup',
])->desc('Deploy your project');

Is being ignored by deployer and it executes instead the following commands:
image

And runs into a locked-state. Note that right after update_code it should actually "force" unlock - testing purpose since I was wondering why I kept run into a locked state.

Any ideas to this?

Use "replace" in composer.json

What do you think about adding replace to composer.json?

replace: {
  "deployer/deployer": "self.version"
}

Then it's possible to install additional packages that require Deployer, but still use deployer/dist in a project while avoiding dependency conflicts.

Namespace declaration statement has to be the very first statement or after any declare call

Installing 7.0.0 RC3 on Windows 10 and PHP 7.4, when I execute I get:

λ .\vendor\bin\dep.bat
PHP Fatal error:  Namespace declaration statement has to be the very first statement or after any declare call in the script in D:\projects\example\vendor\bin\dep on line 13

Fatal error: Namespace declaration statement has to be the very first statement or after any declare call in the script in D:\projects\example\vendor\bin\dep on line 13

When I take a look at vendor\bin\dep, the namespace declaration is the first statement.

PHP Warning: Constant already defined

Invoking dep yields a PHP warning:

$ dep --help
PHP Warning:  Constant  already defined in /.../vendor/deployer/dist/dep on line 5

Warning: Constant  already defined in /.../vendor/deployer/dist/dep on line 5
Description:
  List commands

Usage:
...

This issue does not occur with deployer/deployer.

Environment:

$ php --version
PHP 8.0.14 (cli) (built: Dec 20 2021 21:22:57) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.14, Copyright (c) Zend Technologies
    with Zend OPcache v8.0.14, Copyright (c), by Zend Technologies

Missing latest 4.x releases

The latest 4.x releases are not present in this repository. Could you please add new dist packages for them, at least for the latest version?

rc3 doesn't work

rc3 does not when imported into a project

$ composer dep deploy prod
> dep 'deploy' 'prod'
Script dep handling the dep event returned with error code 255

Unfortunately I can't use rc4 either as it has another bug:

$ composer dep deploy prod
> dep 'deploy' 'prod'
task deploy:info                                                                                               
[prod] info deploying develop
task deploy:setup
task deploy:lock
task deploy:release
task deploy:update_code
[prod]  error  in update_code.php on line 84:
[prod] run export GIT_TERMINAL_PROMPT='0' GIT_SSH_COMMAND='ssh -o StrictHostKeyChecking=accept-new'; cd ~/application/prod/.dep/repo && (/usr/local/cpanel/3rdparty/lib/path-bin/git remote update 2>&1)
[prod] Fetching origin
[prod] command-line line 0: unsupported option "accept-new".
[prod] fatal: Could not read from remote repository.
[prod] Please make sure you have the correct access rights
[prod] and the repository exists.
[prod] error: Could not fetch origin
[prod] exit code 1 (General error)
task deploy:failed
task deploy:unlock
Script dep handling the dep event returned with error code 1

Unable to use phpstan without the `.phar` extension

I'm working on a package with custom recipes and would like to use phpstan, but it dosen't work, because the distribution file has no extension.

The following config works with phpstan when I rename dep to dep.phar.

parameters:
    bootstrapFiles:
        - phar://vendor/deployer/dist/dep.phar/vendor/autoload.php

Would it be possible keep the extension in the distribution and to add a symlink to keep backward compatibility?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.