The dotland's discuss from denoland

Unexpected link - missing "/" at the end of "/std"

Gatsby?

If you are using netlify have you considered using Gatsby?

fix spinner on benchmarks page

wanted: Add search input to registry page

We already have more than 120 modules listen in registry. It'd be very useful to have a small search box at the top of the registry page than you could filter out the list.

I'd imagine that search box is focused by default when you visit the page and can be used to filter by name/description fields of the module.

can i help you?

Hi Ryan,

Can i help you with site?

I have a lot experience work with React and i have a free time.

Support documentation and source viewing for arbitrary URLs

https://deno.land/docs?url=https://unpkg.com/browse/[email protected]/chain/chain.js

This should simply reuse src/Docs.tsx

Shell commands aren't highlighted on homepage

Problem

Shell commands on https://deno.land/#install aren't rendered as code.

This overflows on mobile allowing to scroll on the y-axis
It's inconsistent with other pages like https://deno.land/std/manual.md#setup

Solution

Modify the install and example commands in Home.js to use <CodeBlock/>

[security] can inject JS into page via markdown files

Currently it is possible to inject javascript into pages that render markdown using, for example, a <img> element. This element has an onload parameter that will execute any JS that is passed to it once is succeeds/fails in loading the image.

Instead of blacklisting tags like we do now - currently only <script> is blacklisted - we should whitelist 'known good' tags like comments and <div>. The whitelist Github uses is more complex and is 'documented' here. It also takes the actual params of the tags into account.

500 Internal Server Error for misspelled module names

I noticed a difference between 404 of wrong path of a good module and a bad module.

Bad path of a good module gives HTTP 404 Not Found response and a short body but no Content-Type header:

$ curl https://deno.land/x/dirname/wrong-file.ts
404: Not Found

But when there is a mistake in the module name, the status is 500 Internal Server Error with Content-Type: text/html; charset=UTF-8 and a lot of HTML, even when requested by curl:

$ curl https://deno.land/x/wrong-module/mod.ts
<!DOCTYPE html>
<!--[if lt IE 7]> <html class="no-js ie6 oldie" lang="en-US"> <![endif]-->
<!--[if IE 7]>    <html class="no-js ie7 oldie" lang="en-US"> <![endif]-->
<!--[if IE 8]>    <html class="no-js ie8 oldie" lang="en-US"> <![endif]-->
<!--[if gt IE 8]><!--> <html class="no-js" lang="en-US"> <!--<![endif]-->
[...]

benchmark plots don't display well on mobile

they're not using all the available horizontal real-estate

add unit tests

set it up here https://github.com/denoland/deno_website2/blob/fbe617646c93dfff919d4d70722be82e5527e3f0/.github/workflows/build.yml#L16
and no need to add comprehensive tests, just add an example of how to test react (a good example test would be to check that the home page renders properly and contains the word "Deno")

Benchmark charts - bad values for throughput and exec time

If you check latest benchmarks (https://github.com/denoland/deno/runs/274208380) you can see that both of those charts should be <2s but all of the results are >4s on charts.

CC @lucacasonato @ry

Add a field to database.json for main entry point of module

I want people to be able to import pogo from 'https://deno.land/x/pogo', but right now that doesn't work because the registry doesn't know which file to point to.

It would be great if I could specify the main entry point in database.json.

I created module-url to make this a bit easier. It is a utility that takes an object as input, in nearly the same format as is used in database.json, and it returns a URL string of where to fetch the module from.

Hash links do not anchor on click in /std/manual.md

Same as #78.

Related to #70, #104

Visiting http doesn't redirect to https

Not sure if this is the right place for this, but here goes.

First time visit to deno.land (no prior visits) serves up the http version rather than https. Not sure if I'm missing something but I assume redirecting to https is preferable.

To repeat this behavior, cookies should be cleared (obviously) and visit http version or just type deno.land

Just thought I'd let you know.

Watching the project with interest.

Benchmarks: link to hyper_hello.ts is broken

Benchmarks: https://deno.land/benchmarks

Broken link: https://github.com/denoland/deno/blob/master/tools/hyper_hello.rs
This happens because hyper_hello was moved to it's own crate in denoland/deno#2641

add selectable line numbers

Allow selecting lines with URL fragment: http://deno.land/std/http/server.ts#L1-#L5

@j-f1 implemented this already somewhere in https://github.com/denoland/registry/tree/master/src so maybe try to reuse code from there.

Module URL with no trailing slash has broken links

Example:

https://deno.land/x/dirname/ (with slash)
- mod.ts links to https://deno.land/x/dirname/mod.ts (good)
https://deno.land/x/dirname (without slash)
- mod.ts links to https://deno.land/x/mod.ts (bad)

Additionally, the effect of a bad link is a blank screen with no 404 error or any other message.

Example:

https://deno.land/x/nonexistent/path/name

Expected result: 404 error

What is visible: A quick flash of a header and a blank screen.

viewing docs on ts that exports a module causes a blank screen

example: https://deno.land/x/abc/dev_deps.ts

Statements like export { test, runTests } from "https://deno.land/[email protected]/testing/mod.ts"; seem to be the culprit.

doc / repo/ raw buttons have bad margins on mobile

I would prefer we keep the UI very minimal... these buttons do not seem so minimal. Links would be fine - at least they wrap.

API Doc Broken...

The main page API Documentation links to a non-existent page: https://deno.land/typedoc/

benchmark page doesn't work on mobile

viewing docs on non ts files causes a blank screen

We should only display the documentation button on supported formats.

HTML code showing up between markdown.

@ry, The prettier HTML code is being shown between markdown. I was also trying to make the toc but its not being rendered properly. Please guide how to solve this. Would like to work on it. Thanks.

This screenshot is from the Manual page.

Page loads too slowly

The current page load resource is too slow

And the loaded resource pack is too large

we should add babel-import-plugin plugin

Load components on demand

Then the component/router should be loaded dynamically

eg. Chart component

Proxy arbitrary repos from deno.land/x/?

Would it make sense to allow the viewing / proxying of any repo from https://deno.land/x/?

e.g. something like https://deno.land/x/gh/USERNAME/MODULE_NAME@BRANCH/SCRIPT.ts for GitHub. Or maybe just https://deno.land/gh/....

Gitlab and others could be supported with alternate reserved prefixes. Just thinking about the long term editorial and maintenance contract of database.json. But maybe its perhaps intended as an editorialized / secondary std.

It seems like maybe the idea behind https://deno.land/x is similar to that of https://godoc.org and/or the go module proxy?

docs broken for https://deno.land/x/mysql/src/client.ts

Change to the Registry Page.

Hi,
In the registry page the top menu (Documentation, Repository, Raw) are displayed with BR and takes extra vertical spaces especially in mobile view.

I want to change this menu to inline horizontal view:

Documentation | Repository | Raw

Please let me know if you agree with this minor change to PR.

Thanks

@lucacasonato

order the data in benchmark menu

This is difficult to read

support viewing images in registry

We should probably support viewing images in the registry rather than just showing weird chars in code blocks.

Also for markdown pages.

Also support branches properly.

https://deno.land/std/ (OK)
https://deno.land/[email protected]/ (NOT FOUND)

(With no trailing slashes it's the same, plus additionally #116 happens.)

404 errors from date_fns JS files in registry

If you visit this page: https://deno.land/x/date_fns/addMonths/index.js you'll see a 404 error.

This reporter seemed to think it was an issue with JS files: https://github.com/denoland/registry/issues/177

However, if you look at the "repository" link on the index.js page linked above, you'll see it points to: https://github.com/date-fns/date-fns/tree/mastersrc/addMonths/index.js

Note /tree/mastersrc/, which should actually be /tree/master/src/. I suspect this might have something to do with the handling of the path parameter in database.json: https://github.com/denoland/deno_website2/blob/92a20e81c51c051080311c2edefe517049dbafcd/src/database.json#L116

Note the old registry code has a leading /: https://github.com/denoland/registry/blob/714ffcf29d55620fb02b53c99c7d954a366a19e7/src/database.json#L116