denniskehrig / brackets-show-whitespace Goto Github PK

View Code? Open in Web Editor NEW

68.0 68.0 25.0 60 KB

Show Indentations in Brackets

License: MIT License

JavaScript 88.12% Less 11.88%

brackets-show-whitespace's People

Contributors

Stargazers

Watchers

brackets-show-whitespace's Issues

White space not showing

Hi guys,

This issue is fixed.

Sorry !

Can't superceed CSS styles with themes

I'm using my own version of Solarized Light theme for Brackets editor, so the default colors are less than optimal. Seems others would like to tweek the CSS also. IMHO, I think editing the theme.css is ideal, so we don't have our main.less edits written over by a new update.

Unfortunately, any overrides I try in my own theme will not take. I've tried using both MiguelCastillo/Brackets-Themes & Jacse/themes-for-brackets with no luck. So here is my result:

Workaround: edit the main.less inside /brackets-show-whitespace, but will break on updates.

Thanks for this great plugin; I missed being able to find whitespace since I moved from Notepad++. & the .cm-dk- namespace is a great idea.

Performance Issues Release 0.44 OSX

I updated Brackets today and noticed a huge amount of lag. It took about 1-3 seconds for Brackets figure out I was trying to do anything and I noticed my CPU temp spiked from 60c to 85-90c with only Chrome and Brackets running.

I started removing all of of my plugins one by one. I only use a few. After I removed Show Whitespace everything was back to normal, mostly. Brackets still runs kind of slow, but it could be because of the whole split view things being new.

I have a newer MBP. There's no hardware reason for Brackets to be lagging.

I hope somehow you could get this fixed. This is one of my favorite plugins! I feel like my code is naked without it.

Scrolling performance issue

When show whitespace is enabled, scrolling performances are extremely poor, even on a small-medium file (~200 lines).
Bracket version: sprint 36
OS: Mac OSX Mavericks
15" MBP Late 2011 (non-retina)

Whitespace is not displayed immediately after startup

View > Whitespace
I can see spaces (dots) and tabs (horizontal lines)
Shutdown and restart Brackets

Results:
The menu item View > Whitespace is still checked, but whitespace is not displayed

Expected
Highlighting reflected by check next to menu command

Note that if I disable and re-enable View > Whitespace, it works again.

feature request,show the difference between `space` and `tad` just like sublime text

README is highly out of date

It should be updated before release, as well as a change log added.

[Feature] Only show on selected text

Would be nice to have an option to only show tabs and spaces of the selected text ;-)

Publish the current version to Brackets Registry

I noticed that the current version according to package.json is "version": "2.1.0", while the version on the registry is 2.0.1:

Show Whitespace 2.0.1
by Dennis Kehrig / DennisKehrig on 2014-05-29 
Visualizes whitespace similar to how Sublime Text does it

Unless there's something blocking this, I see that @DennisKehrig hasn't been online for a bit so that might complicate things a bit (unless changing the package name a bit is okay)

Localization support

There should be support for translating the “Show Whitespace” menu item.

Update preferences code for Sprint 37

OS: Mac OSX Mavericks

Brackets Version: sprint 37 experimental build 0.37.0-12014 (release abbda8dd2)

Extension Version: 2.0.0

Repro Steps:

Open Brackets with Themes extension installed
Open Developer Tools and look at console.

Observed Results:
Warning about using getPreferenceStorage().

Expected Results:
No warnings in console.

Option to show the "space marks" following the indentation settings

The brackets-show-whitespace is doing a great work at all. Thanks. Anyway, I'd like to suggest an enhancement that may improve the user experience.

In the current version, we get something like:

<!DOCTYPE html>
<html lang="en">
..<head>
....<meta charset="utf-8">
..</head>
..<body>
....<p>...</p>
....<div>
......<div>
........<p>...</p>
........<p>...</p>
........<p>...</p>
......</div>
....</div>
..</body>
</html>

In order to make the code view cleaner, it could be nice if there is an option to only show the "space mark" on indentation points, e.g: same as Sublime Text does. So, we would get something like:

<!DOCTYPE html>
<html lang="en">
  <head>
  . <meta charset="utf-8">
  .  </head>
  .  <body>
  .  .  <p>...</p>
  .  .  <div>
  .  .  .  <div>
  .  .  .  .  <p>...</p>
  .  .  .  .  <p>...</p>
  .  .  .  .  <p>...</p>
  .  .  .  </div>
  .  .  </div>
  .  </body>
</html>

only show leading and trailing white space

Thought I'd throw my two cents in here... I don't like seeing the spaces between attributes in my html tags. I also think that the contrast is still too strong but that's probably user preference at this point. Here's what i've adjusted on the "obsidian" theme:

.CodeMirror .cm-dk-whitespace-leading-space:before, .CodeMirror .cm-dk-whitespace-leading-tab:before{
background: #667a82;
}
.CodeMirror .cm-dk-whitespace-space:before, .CodeMirror .cm-dk-whitespace-tab:before {
background-color: transparent;
}

Opacity

Hi,

The current opacity can be quite intrusive.

Can I suggest an addition to lines 44 and 53 of main.less.

Adding in the following:

opacity: 0.2;

A really useful plugin.

Thanks,

Brian

Lodash 3.x support

As part of #31, I've introduced a dependency on Lodash, which is available in Brackets core. There are plans of updating Brackets to use the new version, and in doing so, the new usage of ._template might break. Track progress of the upgrade and update this extension accordingly.

References

deletes a word under unknown circumstances (reproducible)

Very weird, might be interesting :)

Demo (video)
https://mega.co.nz/#!ZdlA2ZzK!nojTiqyf2KoJcrk4O7-NmklDWAUXbZd97kzOW7Q3JS4
word gets deleted on mouse right-click.

Repro

Use project:
https://mega.co.nz/#!1QknhJ5a!PtE7aChn_lZx_KIlIY0FFB-gpzmo-ZBpBfpD2WupVkk
Open test.js
search for tabstrip
set cursor/carret with left mouse click after w in newTabstrip
click right mouse button

Expected
Context menu opens.

Happens
word gets deleted and the context menu opens

Note
I'm not sure whether this bug depends on codemirror or some brackets config or internal brackets bug. I could not debug any deeper, as I start changing the file/text and saving/opening/restarting brackets the bug goes away.

All listeners are leaky

This is a not a new issue, but it is heightened when #31 lands. Despite the presence of the unload() function that tears down and properly closes everything, as far as I can tell that function is never called. I can't seem to log any instance of it or the functions it calls being run when the extension is disabled. Unless it is implicitly run by Brackets and any logs suppressed, all listeners leak until the program is closed or restarted. Obviously, that is not good. That unload() function needs to be called. Investigate how we can do that and unregister the listeners.

Deleted

Arrow selection and navigation very slow when Show Whitespace is toggled

OS: Windows 7

Build: sprint 31 development build 0.31.0-0 (master 2e800ef3a)

This issue is spun off of a discussion in adobe/brackets#4862, where I realized that the performance of arrow selection and navigation is very slow going from Sprint 29 to Sprint 30. I discovered a bit of the problem was caused by my Indent Guides extension and also that I could repro the problem really well when Show Whitespace is toggled on.

I know this extension code pretty well and I don't think there is anything to be done to address this issue directly. It is probably caused by the overlay code and the new Chrome CEF not handling all of the stylized spans very well. I am hopeful that a solution to adobe/brackets#5000 may help address this issue as well.

I consider this pretty low priority since a simple workaround is to toggle the Whitespace off but it provides good documentation and a consistent repro test to use as we attempt to solve this performance problem.

Add package.json file

The extension manager entry for Show Whitespace is looking pretty barren :).

If you need a reference, here's a link to the package.json for Indent Guides:

https://github.com/lkcampbell/brackets-indent-guides/blob/master/package.json

Whitespace glyphs are not displayed in inline editor

The README says this should work. Maybe this was introduced with CodeMirror v3.

[Linux] Middle mouse button paste only pastes "$" (extension error)

Linux]
When selecting a text with the mouse and then doing a middle-button-paste I only get a $ instead of the pasted text.

OS: Ubuntu 13.04,
Desktop Environment: gnome 3.8.0,
Architecture: x86_64 / amd64
Brackets Version: 0.34.1-10733 (binary install (.deb) from website).
Extensions: Show Whitespace, Pretty Json

This seems to be an problem with the "Show Whitespace" extension.
When I disable that extension middle-button-paste works.

feature request:trim automatic white space when file saving just like sublime text

Remove CodeMirror 2 support

Brackets has been using CodeMirror 4.x since May 2014, the minimum supported Brackets version (sprint 31) is from September 2013, and we are now on release 1.1. Any CodeMirror 2 code is no longer applicable, and thus should be dropped and the minimum version raised to sprint 38.

Feature Request: show all white-space

Dennis, this is an awesome extension. Why limit it to only the indentation? I'd like to visualize all white-space.

I also recently discovered the unicode "no size" space char. It would be nice to know if I had one of those in my file! :)

Is there a way to turn off viewing of tab symbols in the document

I posted this to the brackets forum. Screen shot at bottom. Thanks!

https://groups.google.com/forum/#!searchin/brackets-dev/wyattbiker/brackets-dev/wdNtb7UDs7Q/NaQ_0I6B4qoJ

Broken in Brackets CodeMirror v3

This extensions doesn't seems to work in Brackets CM v3 (which was merged into master today).

Problem only seems to happen if there's a file in working set (and displayed in editor) at startup. The var _super is undefined when this call is made (line 113):

    var html = _super.apply(this, arguments);

Unfortunately, Edge Code Preview 3 will have CM v2 (where extension works), but Brackets Sprint 20 will have CM v3, and both will be released at about the same time.

Want add a new style like sublime2

Conflict with extension "Indent Guides for Brackets"

Hi,

I have just installed your extension and it works perfectly.
But I Notice that it create a "conflict" with "Indent Guides for Brackets" (https://github.com/lkcampbell/brackets-indent-guides)

Your "override" behavior of the other extension.

I have created an Issue to the other on too.
I looked your code (and the other on), but I'm too novice to help you =/

Thanks

Whitespace size does not grow/shrink with the editor font size

Upload extension to Brackets extension registry

Hey Dennis! I know you're busy with other stuff, but when you get a chance, would you mind uploading your extensions to the Brackets extension registry?

Here's more info on how to upload your extension to the registry: https://github.com/adobe/brackets/wiki/Extension-Registry-Help. It's pretty simple: you just have to create a package.json file if you don't already have one, make a zip file, and then drag and drop it into the registry web app.

Also--once you've uploaded your package to the registry, if you could move it to the "Moved Extensions" section of the old Brackets Extensions wiki page (https://github.com/adobe/brackets/wiki/Brackets-Extensions) that would be great.

Thanks!

(I'll only post an issue in this repo to avoid spamming you, but it would be great if you could upload your other extensions too.)

Allow users to change the color of the whitespace

With themes becoming standard in 0.42, the color of the whitespace should not be hard coded. The whitespace is too bright on the newly added default dark theme, for instance. Would it be possible to add a setting to configure the color ourselves to best match the theme we are using?

Fainter dots

The whitespace characters are a little bit overly "bright", perhaps making them transparent would help?

denniskehrig / brackets-show-whitespace Goto Github PK

brackets-show-whitespace's People

Contributors

Stargazers

Watchers

Forkers

brackets-show-whitespace's Issues

References

Recommend Projects

Recommend Topics

Recommend Org