denislabrecque / jquery-ui-fixed-for-3.5.1

Fix jQuery 3.3.0 migrate warnings on jQuery UI 1.12.1 when using jQuery 3.5.1

Fix jQuery 3.5.1 Migrate Warnings for jQuery UI 1.12.1

jQuery UI releases have gone stagnant since 2017. Therefore, they contain deprecations of jQuery. The goal is just to correct those statements that need fixing, and change nothing else. These are the warnings:

JQMIGRATE: jQuery.expr[':'] is deprecated; use jQuery.expr.pseudos

JQMIGRATE: jQuery.expr.filters is deprecated; use jQuery.expr.pseudos

JQMIGRATE: jQuery.isArray is deprecated; use Array.isArray

JQMIGRATE: jQuery.isFunction() is deprecated

According to a discussion thread, this is already done in UI code, but is not included in a single release.

Use this code at your own risk. Though every effort has been made to write correct changes, I do not know how to test them fully. Also, lower versions of jQuery might have had other issues that were not fixed, like jQuery.unique is deprecated, use jQuery.uniqueSort, which are not warned about in the above configuration.

jquery-ui-fixed-for-3.5.1's Issues

Missing parenthesis for typeof test.

typeof test should be wrapped in parenthesis for the not (!) operator to have expected effect here:

jQuery-UI-Fixed-for-3.5.1/jquery-ui-1.12.1.js

Line 251 in 23ba1fd

if ( !typeof( instance[ options ] ) === 'function' || options.charAt( 0 ) === "_" ) {

like this one:

jQuery-UI-Fixed-for-3.5.1/jquery-ui-1.12.1.js

Line 123 in 23ba1fd

if ( !( typeof value === 'function' ) ) {