delightedcrow / habiticamagic Goto Github PK

#5

#6

As reported in delightedCrow/MMM-HabiticaStats#1

in the HabiticaMagic code here https://github.com/delightedCrow/HabiticaMagic/blob/master/src/HabiticaAPIManager.js#L130 you're resolving the Promise without an error only if the code is 200 but for example the content api often returns a 304 code if the browser (in this case the Electron app) has already cached the last version of the file and nothing has changed. It would be considered as an error even though it's not. I would suggest to use an external library that's been built specifically for making AJAX requests as it's not easy to make it right (for example jQuery.ajax, axios) or the Fetch API which is now available in every browser https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch

Using promises for functions like HabiticaAPIManager.fetchContentData() instead of callbacks would make life (and code) so much easier.

postRequests should be added