delcroip / dolibarr_project_timesheet Goto Github PK

🐛 The signature of the fetch method of projet/class/task.class.php changed in Dolibarr 7, but the timesheet does match this signature, thus sending a warning:

Warning: Declaration of TimesheetTask::fetch($id, $ref = '') should be compatible with Task::fetch($id, $ref = '', $loadparentdata = 0) in D:\htdocs\www\dolibarr-7.0.2\htdocs\timesheet\class\TimesheetTask.class.php on line 27
--


1 | 0.0024 | 519368 | {main}( ) | ...\index.php:0
2 | 0.3893 | 9711256 | FormOther::getBoxesArea( ) | ...\index.php:81
3 | 0.3900 | 9756992 | InfoBox::listBoxes( ) | ...\html.formother.class.php:990
4 | 0.4542 | 14256504 | dol_include_once( ) | ...\infobox.class.php:107
5 | 0.4549 | 14279088 | include_once( 'D:\htdocs\www\dolibarr-7.0.2\htdocs\timesheet\core\boxes\box_approval.php' ) | ...\functions.lib.php:653
6 | 0.4557 | 14355344 | require_once( 'D:\htdocs\www\dolibarr-7.0.2\htdocs\timesheet\core\lib\timesheet.lib.php' ) | ...\box_approval.php:25
7 | 0.4582 | 14773184 | require_once( 'D:\htdocs\www\dolibarr-7.0.2\htdocs\timesheet\class\TimesheetUserTasks.class.php' ) | ...\timesheet.lib.php:69
8 | 0.4635 | 15480808 | require_once( 'D:\htdocs\www\dolibarr-7.0.2\htdocs\timesheet\class\TimesheetTask.class.php' ) | ...\TimesheetUserTasks.class.php:27

Links toward project in the timesheets pages don't change the left menu when clicked upon

in the home screen, when one want to add a widget BoxApproval is shown instead of a human readable description

in timesheet/class/Task_time_approval.class.php, line 275

If provided by the user, the value of $id may allow an SQL injection attack. Avoid concatenating parameters to SQL query strings, and use parameter binding instead.

		$sql.=' t.fk_project_task_timesheet,';
		$sql.=' t.note';

		
        $sql.= " FROM ".MAIN_DB_PREFIX.$this->table_element." as t";
        $sql.= " WHERE t.rowid = ".$id;

    	dol_syslog(__METHOD__);
        $resql=$this->db->query($sql);
        if ($resql)
        {

Posted from SensioLabsInsight

timesheet notes on task level are not saved

Approval working but an error message is showed instead of a sucess message

Hello,

Version used: 3.2.0 on Debian 9/PHP7

If you want see a Report User view with the export friendly option, the dates are the number of seconds since 1970, not the DD/MM/YYYY format.

I think it's an issue around TimesheetReport.class.php file.

Thanks for fix

Hello

I have been looking through this thread (https://www.dolibarr.org/forum/511-creation-of-a-new-module/25010-timesheet-module?start=20 ) and was wondering if you could help me.

I need something similar created for my small shop. I have just started to hire one/two employees on temporary basis. Your timesheet module is currently based on PROJECTS.

I need a timesheet module based on users/employees which can do the following:

· Be based on Dolibarr users

· Have user permissions

· Allow users to submit their timesheets to admin based on start/finish times per day and total hours would be automatically calculated.

· Allow emails to notify user/admin of timesheet submission/approval and then a weekly cron email to admin to give summary of users and hours and amount to be paid (based on user hourly rate)

· Allow to generate pdf OR be able to print timesheets/summaries which are printer-friendly

· Allow user to see their own timesheets

· Allow admin to record/mark/tag rules or entries (e.g. lates, absence, sick, shift swap)

· Allow admin to use Dolibarr calendar with filter only to show staff on/off days etc

I can’t seem to find anything similar for users (not project-based) in or out of Dolibarr which is open source and active. I tried a few types of applications but everything is project-based. Then I thought if I can find something linked within Dolibarr with read/write user permissions it would be better (all in one place).

I hope you can help me. Your feedback would be highly appreciated.

My setup: Dolibarr 5.0.4 on PHP7 and MySQL on a CentOS VPS. I also have a private repository if that helps.

Regards,

Imran # #

Despite the chosen sorting/grouping the result seams to be sorted by date

Closed project shouldn't be showed in the invoice drop down list --> should show none closed project only

PostGreSQL doesn't support enum, all enum need to be transformed into int; changes mostly done

We use your module to track time spent for customer support. The billing is then carried out quarterly.
It would be nice to have an option to report/invoice a calendar quarter instead of a single month.

Kind regards
Nino

an user that deals with lots of tasks asked to have a kind of sorting /search mechanism for the task list so he won't have to search himeself

Defect reported mikael paillet, TBC

Progression is not showed in TS

If the timesheet configuration is sent when the session is lost then all the variables are back to null

Removing the time should be accepted as 0 h

When upgrading from version 1.5.1 to version 2.0, SQL errors are appearing, saying that the table "llx_project_task_time_approval" is missing.

Not translated

• Submit Querry
• SubmitAndValidate
• Personnalisé iso Personalisé in select ( invoice)
• timesheetSubmitted in timesheet page (in Notify)

the report should be in day if the mode days is selected

I installed Dolibarr version 6.0.3 as server on Windows 10. I downloaded timesheet from github ans unzipped to the folder //dolibarr/www/htdocs/custom/

When I open dolibarr, I can see that there is timesheet module under settings/Modules. I enable the module.
When I press settings of the module I get below message:

"""
Fatal error: Arrays are not allowed as constants in C:\dolibarr\www\dolibarr\htdocs\custom\timesheet\core\lib\includeMain.lib.php on line 33
"""

Also, if I press the "Timesheet" button at the top, I get the same message.

Thanks in advance.

handle the favori with tab ( iso page) like the Setup tab are done ( pure JS)

• Approver not translated
• Icon are to big

Il doit y avoir un petit souci sur le total des lignes par projet, quand on gère le temps par heure.
Pour un temps total sur une tache de 2 h 55 il semble indiquer 2.9013888888889:55
Sinon, excellent module, merci

if TS is not accessed via the top riblon then the left menu isn't displayed

🔒 There are major security issues:

• Database queries should use parameter binding -> SQL injection
• Global variable or function should never be used -> harder to maintain
• Source code should not contain FIXME comments -> unreported and unfixed issues
• exit() and die() functions should be avoided -> use exceptions instead
• Files should not be executable ->potential security breach

See SensioLabs analysis reports for more details:

the date should stay the same after pushing getReport for both user and project report

01 &02 of April are missing in the timesheet in week mode