Comments (11)
Checking 👀
from dekart.
v0.12.1-rc.0
is already deployed to playground.
from dekart.
@pooriaPoorsarvi so I tried to fix kepler.gl, but I after fix in one place I receive error in the other place; It does not seam update flow works well in kepler.gl 😐
I use my variation of your fix logic: save config, remove dataset and add it again
https://github.com/dekart-xyz/dekart/pull/98/files
from dekart.
Hey @pooriaPoorsarvi
It appears that addDataToMap in Kepler library sometimes fails with such error
Issue is partially addressed by v0.12.1-rc.0
(v0.12.1
will come soon): now correct error message will be displayed with reload button (which commonly helps). Next step will investigate and fix it in kepler fork.
from dekart.
@delfrrr Thanks! is the dependency update also deployed on the master branch (or for the Kepler.gl fork made by the dekart team)?
from dekart.
In v0.12.1
there is only error handling, not fix for kepler.gl
dekart uses already fork of Kepler with few bugfixes https://github.com/dekart-xyz/kepler.gl/pkgs/npm/kepler.gl
when fix ready it will be integrated to dekart main branch.
from dekart.
@delfrrr I see; thanks for the update! We do have a possible workaround that we are using in our fork of dekart.
From what I observed, this error only happens on updating the data (so using addDataToMap for an existing dataset id), so the workaround, is to remove the dataset before adding in the updated version.
This could cause a bug which is, the visualization being reverted back to default on rerunning a query, but a simple fix for that is to save the visState of Kepler.gl before running the query, and then retrieving the layer, and the filters related to that dataset id, after we have removed it and then adding it back before adding back the new data.
from dekart.
@pooriaPoorsarvi can you please share code of your workaround?
from dekart.
@delfrrr Sure, it's a work in progress that I'm gonna change soon (for example instead of storing things in local storage you could use redux, and there are some other information that needs to be updated) but here is the gist of it:
before the query starts running we save the current state of kepler.gl : https://github.com/pooriaPoorsarvi/dekart/blob/c95c9a7539acf228f13ca02708f65cd531d7d761/src/client/Query.js#L206
We can't rely on the existing system because that is made for when the user saves the report, and that saves it to the backend. But we need to have a consistent view even if the user reruns a query after a minor change (without saving it).
Then once a query has ran, if a dataset layer already exists for it within Kepler, we remove it, and readd the new data, but we use the information we saved from the previous step to make it look like it has the same visual state: https://github.com/pooriaPoorsarvi/dekart/blob/custom-authorization/src/client/actions/dataset.js#L93:~:text=id)%3B-,dispatch(keplerRemove(dataset.id)),%7D,-await%20dispatch(
from dekart.
@pooriaPoorsarvi fix is available in 0.12.2-rc.0
from dekart.
@delfrrr Thank you! will merge it soon with our own code!
from dekart.
Related Issues (20)
- AI queries (generate query based on AI request and db schema) HOT 4
- Time series
- Embed map in Confluence
- Concurrent Map read and map write
- [Feature] Add in hatched and dotted symbology
- [Feature] Add labels to polygons
- Illegal base64 data at input byte 326
- Select Project ID and Storage Bucket over UI
- Save maps annotations
- [Bug] Slack link is no longer active
- [Bug] Because of the Button spinner, user can't choose the team plan again
- [Bug] query names lost upon forking report
- [Bug] kepler.gl layers are reordered when a query is refreshed
- [Feature] option to not change map view upon query refresh
- [Feature] scheduled auto-refresh
- [Bug] can't invite more than 1 team member HOT 1
- Add DuckDb support MVP
- Config Name Is Incorrect For Data Source In Documentation HOT 5
- [Feature] Provide Support for Uploading Json files HOT 3
- auto conversion of data types? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dekart.