Comments (5)
hello @truly-indian , thanks for opening issue.
we have Dekart database for storing metadata and DEKART_POSTGRES_DATA_CONNECTION to manage only data to visualize.
what do you mean it is incorrect?
as I understood, you want to extend the name from DEKART_POSTGRES_DATA_CONNECTION to DEKART_POSTGRES_DATASOURCE_CONNECTION
from dekart.
@Tsovak As you mentioned you have DEKART_POSTGRES_DATA_CONNECTION to manage only data to visualize. What I am saying is that in the code where you are connecting to PG you are using the config name as DEKART_POSTGRES_DATASOURCE_CONNECTION and in the documentation you are stating the config to be used as DEKART_POSTGRES_DATA_CONNECTION which is misleading and wasting a lot of developer time.
Please refer this line of code. The config name used here for pg connection is wrongly mentioned in the documentation.
dekart/src/server/pgjob/pgjob.go
Line 31 in 2c1ac71
from dekart.
@Tsovak As you mentioned you have DEKART_POSTGRES_DATA_CONNECTION to manage only data to visualize. What I am saying is that in the code where you are connecting to PG you are using the config name as DEKART_POSTGRES_DATASOURCE_CONNECTION and in the documentation you are stating the config to be used as DEKART_POSTGRES_DATA_CONNECTION which is misleading and wasting a lot of developer time.
Please refer this line of code. The config name used here for pg connection is wrongly mentioned in the documentation.
dekart/src/server/pgjob/pgjob.go
Line 31 in 2c1ac71
I see. It's my mistake.
In the code, it calls DATASOURCE_CONNECTION in the env variable called DATA_CONNECTION in documentation as well.
it should be called DATASOURCE to keep a naming convention consistent with other parts of the project.
Thanks a lot for contributing to the project.
from dekart.
the related PR opened to fix the documentation dekart-xyz/www#35
from dekart.
Great, merged doc PR, thank @Tsovak , @truly-indian
from dekart.
Related Issues (20)
- AI queries (generate query based on AI request and db schema) HOT 4
- Time series
- Embed map in Confluence
- Concurrent Map read and map write
- [Feature] Add in hatched and dotted symbology
- [Feature] Add labels to polygons
- Illegal base64 data at input byte 326
- Select Project ID and Storage Bucket over UI
- Save maps annotations
- [Bug] Slack link is no longer active
- [Bug] Because of the Button spinner, user can't choose the team plan again
- [Bug] query names lost upon forking report
- [Bug] kepler.gl layers are reordered when a query is refreshed
- [Feature] option to not change map view upon query refresh
- [Feature] scheduled auto-refresh
- [Bug] can't invite more than 1 team member HOT 1
- Add DuckDb support MVP
- [Feature] Provide Support for Uploading Json files HOT 3
- auto conversion of data types? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dekart.