Config Name Is Incorrect For Data Source In Documentation about dekart

[Tsovak]

hello @truly-indian , thanks for opening issue.
we have Dekart database for storing metadata and DEKART_POSTGRES_DATA_CONNECTION to manage only data to visualize.
what do you mean it is incorrect?
as I understood, you want to extend the name from DEKART_POSTGRES_DATA_CONNECTION to DEKART_POSTGRES_DATASOURCE_CONNECTION

[truly-indian]

@Tsovak As you mentioned you have DEKART_POSTGRES_DATA_CONNECTION to manage only data to visualize. What I am saying is that in the code where you are connecting to PG you are using the config name as DEKART_POSTGRES_DATASOURCE_CONNECTION and in the documentation you are stating the config to be used as DEKART_POSTGRES_DATA_CONNECTION which is misleading and wasting a lot of developer time.

Please refer this line of code. The config name used here for pg connection is wrongly mentioned in the documentation.

dekart/src/server/pgjob/pgjob.go

Line 31 in 2c1ac71

dbConnStr := os.Getenv("DEKART_POSTGRES_DATASOURCE_CONNECTION")

[Tsovak]

@Tsovak As you mentioned you have DEKART_POSTGRES_DATA_CONNECTION to manage only data to visualize. What I am saying is that in the code where you are connecting to PG you are using the config name as DEKART_POSTGRES_DATASOURCE_CONNECTION and in the documentation you are stating the config to be used as DEKART_POSTGRES_DATA_CONNECTION which is misleading and wasting a lot of developer time.

Please refer this line of code. The config name used here for pg connection is wrongly mentioned in the documentation.

dekart/src/server/pgjob/pgjob.go

Line 31 in 2c1ac71

dbConnStr := os.Getenv("DEKART_POSTGRES_DATASOURCE_CONNECTION")

I see. It's my mistake.
In the code, it calls DATASOURCE_CONNECTION in the env variable called DATA_CONNECTION in documentation as well.

it should be called DATASOURCE to keep a naming convention consistent with other parts of the project.
Thanks a lot for contributing to the project.

[Tsovak]

the related PR opened to fix the documentation dekart-xyz/www#35

[delfrrr]

Great, merged doc PR, thank @Tsovak , @truly-indian