The pdiary from deividy

pdiary's People

Contributors

Watchers

pdiary's Issues

Diary entries are not so private

We have a bug that we can listen to any socket.

If we run this:

const wss = new WebSocket('wss://pdiary-live.deividy.com/socket.io/?diaryLink=super-top-secret&EIO=3&transport=websocket')
wss.onmessage = function (msg) { console.log(msg); }

we will see all the updates from super-top-secret link.

Auth service

We need an auth service, so we can provide centralized login (e.g: live-diary and api can use the same service).

Core should not know about zmq/publish data

We should not publish data via our core, we must have a service for that, core should be simple and just do db and centralized logics.

Also, with current approach we have some bugs; if we try to run the core in 2 apps in the same machine we will get an error, since it will try to bind the same address:

/Users/deividy/dev/codeinaction/pdiary/server/core/node_modules/zmq/lib/index.js:442
  this._zmq.bindSync(addr);
            ^

Error: Address already in use
    at exports.Socket.Socket.bindSync (/Users/deividy/dev/codeinaction/pdiary/server/core/node_modules/zmq/lib/index.js:442:13)
    at Object.<anonymous> (/Users/deividy/dev/codeinaction/pdiary/server/core/dao-models/diary.js:3:11)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at module.exports (/Users/deividy/dev/codeinaction/pdiary/server/core/dao-models/index.js:6:17)
    at Object.<anonymous> (/Users/deividy/dev/codeinaction/pdiary/server/core/index.js:13:55)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)

Recommend Projects