dedis / fixbuf Goto Github PK

When deserializing a slice, the slice must already be allocated to the right size. Put it in another way, the length is not transmitted in the fixbuf encoding.
While in itself, this is not problem, I envision that the usability is greatly reduced because of that. Imagine a complex hierarchy of structure, it would be impractical to instantiate every intermediate structure to "just" allocate a slice to the right slice.
Therefore, I'd like to raise the question whether we should embed the length of any slice in the encoding.

Hiyo!

It appears that this code is also used in Kyber which has the MPL license: https://github.com/dedis/kyber/blob/master/LICENSE . I assume that the Kyber license is probably the intended license (since it's a bigger project). Do you think you could re-release this project as MPL as well?

In a function like "func (r typeX) UnmarshalFrom() { r.X = 1 }" the caller will not see r.X == 1, because the modifications happen on the value created by pass by value.

However, if I make a custom-marshalling type using a pointer receiver, then it is never called. If I use a value receiver it is called. This might be because encoding.go:81 calls UnmarshalFrom without having a pointer.

Anyway, it seems to me that custom unmarshalling does not work now.