debukkit / simplefilestorage Goto Github PK

1. Send some kind of warning message when a password is longer than 16 chars, because if it is longer than 16 characters, only the first 16 characters will be used for the encryption.

2. If the password in DB.get("ID", "PASSWORD"); is wrong, it throws an exception:

javax.crypto.BadPaddingException: Given final block not properly padded
at com.sun.crypto.provider.CipherCore.doFinal(CipherCore.java:989)
at com.sun.crypto.provider.CipherCore.doFinal(CipherCore.java:845)
at com.sun.crypto.provider.AESCipher.engineDoFinal(AESCipher.java:446)
at javax.crypto.Cipher.doFinal(Cipher.java:2165)
at com.blogspot.debukkitsblog.Crypt.Crypter.decrypt(Crypter.java:54)
at com.blogspot.debukkitsblog.Crypt.Crypter.decrypt(Crypter.java:33)
at com.blogspot.debukkitsblog.Util.FileStorage.get(FileStorage.java:117)
at dbtest.main(Main.java:37)
Exception in thread "main" java.lang.NullPointerException
at dbtest.main(Main.java:37)

instead, it should either print a message with "Wrong password" or something like this, or it should print out the "garbage" of the decryption result, but not an error. :D

Edit:

3: Please add the ability to specify the password key too in getAll() and printAll() :D

In der Datei Crypter.java zeile 121 wird in der while schleife anstatt resultKey key verwendet.
Dadurch ensteht eine unendlichschleife die am ende in einem Java Heap Space error endet.

Here is what I have added to my FileStorage file:

public int getCountAsInt(){ return storageMap.size(); }

And:

public String getCountAsString(){ return String.valueOf(storageMap.size()); }

What do you think about making separate encoding. It would be good because it will make it platform(and java ) independent.

A Method for getting the HashMap would be useful.
Example:

HashMap<String, Object> List = fs.getAll();
List.forEach(
   (k, v) -> {
      System.out.println(k + ", " + v);
   }
);

You could split it up like this:

/**
* All stored objects in an ArrayList of Objects
* @return all stored objects in an ArrayList of Objects
*/
public ArrayList<Object> getAllObjects(){
   ArrayList<Object> result = new ArrayList<Object>();
   for(Object c: storageMap.values()){
      result.add(c);
   }
   return result;
}

/**
* All stored objects and keys in an HashMap of String and Objects
* @return all stored objects and keys in an HashMap of String and Objects
*/
public HashMap<String, Object> getAll(){
   return storageMap;
}

(This is to short for a Fork + Pull request)

Improvement suggestion: Add the ability to store data in an encrypted format, for example with AES encryption and with a key that can be specified when an object is stored in the database.