deborahk / angular-generic-validator

Defines a generic validator for Angular 2 Reactive Forms

Hi there 👋

🔎 Where to find me:

• YouTube
• Twitter
• Mastodon
• freecodecamp.org

🔭 I’ve published FREE courses on YouTube:

Gentle Introduction to Programming for Beginners (14 lessons)

Gentle Introduction to HTML for Beginners (21 lessons)

Gentle Introduction to GitHub for Beginners (21 lessons)

Gentle Introduction to CSS for Beginners (22 lessons)

Gentle Introduction to Bootstrap for Beginners (14 lessons)

Gentle Introduction to JavaScript for Beginners (17 lessons)

angular-generic-validator's Issues

Dynamic forms will probably be an issue

Hi @DeborahK the genericValidator looks super cool, and I was keen to use this. However while doing a deep dive in the code, I noticed that you subscribe in an ngAfterViewInit method, and in it we fetch all the controls using a @ViewChildren to get the form elements and also subscribe to their Blur Events observable.

If we now have a Form Array and are adding extra tags, then as the component class is already created, our formInputElements will not get updated, and we will not be doing any validation on the newly added Form Controls, and so they will miss out on being validated by the genericValidator.

It may be possible to unsubscribe and then resubscribe each time you add a control, but this didn't feel ideal either.

Anyhow, this may be a possible gotcha, and therefore perhaps worth pointing out in the Read Me.

Form Arrays

Really good generic validator but it does not seem to work with form-arrays. Even if it did how would the user identify the correct error message to display as there would be multiple formcontrols with the same name