deanrad / antares Goto Github PK

Current API:
The first argument to addFilter is the filter function. An optional 2nd configuration argument allows you to specify an action filter in the actionsOfType field.

Desired API:
The existing addFilter API does not change its behavior.
A new filter method will take the ActionFilter first, and create a predicate function which will only execute the provided filter function if that predicate returns true (see existing behavior, tests).

The following should be equivalent:
New way:
filter(/room/, ({ action }) => {})
Legacy way:
addFilter(({ action }) => {}, {actionsOfType: /room/})

The legacy way can be useful when your filter will see all actions - this is the default behavior if a configuration object is not provided in a 2nd argument. The new way allows for rules to be independently added on 'shards' of similar actionTypes.

This would probably use the asteroid.js library.
Easier than Issue #2

A handler attached via on may want to have its completion and error notifications be of a certain type. Currently the type property of the 3rd argument specifies how to wrap next notifications, this issue would bring it full cycle, so the author would not need to resort to concat and processResults: true as is necessary in a case like below.

 return concat(
        from(goodLines.map(line => ({ type: "goodLine", payload: line }))),
        of({ type: "linesDone" })
      )
    },
    { processResults: true }

https://gist.github.com/deanius/5aba8edf0f102a6269dfbf66a325e96b

More complex than Issue #1 , this would involve replacing Meteor's pubsub - perhaps use Apollo-server ?

Closed as stale.